Bug ID: JDK-8188791 Move AppCDS from closed repo to open repo

Versions (Unresolved/Resolved/Fixed)

The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.

JDK 10
10 b36Fixed

This is the first step of the JEP JDK-8185996 - Application Class Data Sharing.

In JDK 9, significant portion of AppCDS code resided in the closed repo. As part of the open-sourcing effort of JDK 18.3, we will move the source code into the open repo.

With this task, the code (implementation and test) is moved verbatim as much as possible. The intention is only to relocate the sources, not to changing existing behaviors, and not to do any sort of refactoring.

Source code refactoring may be desirable, because the old open/closed source code structure had introduced some intermediary APIs to connect code between the two repos. Such API should be removed in a separate RFE (JDK-8197954)

The only functional change in this task is that the UseAppCDS flag is changed from a "commercial" flag to a regular "product" flag. This is because "commercial" flags are not supported by the OpenJDK build.

I will do a further follow up as something has definitely gone wrong here with Ioi and your status.
05-10-2022
Thanks for the further investigation, David! I see the names from the '3 people authored' now. It's a little confusing (non-accurate) that Ioi's name is listed as 'non-author committer' due to the conversion.
04-10-2022
[~jiangli] investigating further this seems partly a github issue. You are listed as the commit author (see git log output) but there is no way to connect jiangli.zhou@oracle.com to any github user account, so github cannot show you - and it doesn't directly seem to show the Author in its UI anyway. If you hover your mouse over the "3 people authored" text you will see your name listed followed by the github names of the co-authors and committer.
04-10-2022
Ok, that's perhaps the cause. Thanks, David!
04-10-2022
[~jiangli] was your email address still current when the git conversion was done? I have to suspect the conversion process simply ignored an invalid email address.
04-10-2022
~iklam, any reason why the author information was changed? http://hg.openjdk.java.net/jdk/hs/rev/78b2ecdd3c4b 8188791: Move AppCDS from closed repo to open repo Reviewed-by: dsamersoff, simonis, minqi Contributed-by: jiangli.zhou@oracle.com, mikhailo.seledtsov@oracle.com, calvin.cheung@oracle.com https://github.com/openjdk/jdk/commit/61e736cbae980433d5b4e547a7d2f159063bced0 8188791: Move AppCDS from closed repo to open repo Co-authored-by: Mikhailo Seledtsov <mikhailo.seledtsov@oracle.com> Co-authored-by: Calvin Cheung <calvin.cheung@oracle.com> Reviewed-by: dsamersoff, simonis, minqi
03-10-2022
https://github.com/openjdk/jdk/commit/61e736cbae980433d5b4e547a7d2f159063bced0
03-10-2022
URL: http://hg.openjdk.java.net/jdk/jdk/rev/78b2ecdd3c4b User: jwilhelm Date: 2017-12-07 09:00:22 +0000
07-12-2017
URL: http://hg.openjdk.java.net/jdk/hs/rev/78b2ecdd3c4b User: iklam Date: 2017-11-28 06:20:10 +0000
28-11-2017
Change the synopsis from "Move AppCDS implementation from closed repo to open repo" to "Move AppCDS from closed repo to open repo", because PTeam has decided to move both implementation and tests at the same time.
01-11-2017

Blocks :	JDK-8180310 - [testlibrary] TestSocketFactory null pointer when updating match bytes
Blocks :	JDK-8188792 - Move AppCDS tests from closed repo to open repo
Relates :	JDK-8190336 - Make sure that AppCDS works on aarch64 platform
Relates :	JDK-8316132 - CDSProtectionDomain::get_shared_protection_domain should check for exception
Relates :	JDK-8197954 - Remove unnecessary intermediary APIs from AppCDS implementation