JDK-8188654 : Upgrade FX build to use gradle 4.3
  • Type: Bug
  • Component: javafx
  • Sub-Component: build
  • Affected Version: 10
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2017-10-04
  • Updated: 2017-11-06
  • Resolved: 2017-11-06
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 10
10Fixed
Related Reports
Blocks :  
Blocks :  
Relates :  
Description
In order to use a post-JDK 9 bootjdk we need to upgrade gradle, since gradle 3.x does not recognize anything > 9 as a valid JDK version.

gradle 4.1 supports JDK 9 and also recognizes "10" as a valid version. Unfortunately, even gradle 4.1 will fail when/if the Java version string is changed to 18.3. See the comments at the end of:

https://github.com/gradle/gradle/issues/2454

which is the bug that they used to add support for a version of Java 10. So we will likely need to move to something > 4.1 when the (yet-to-be-filed) bug is fixed by the gradle team.
Comments
Changeset: ecf62449ebb8 Author: kcr Date: 2017-11-06 11:26 -0800 URL: http://hg.openjdk.java.net/openjfx/10-dev/rt/rev/ecf62449ebb8 8188654: Upgrade FX build to use gradle 4.3 Reviewed-by: prr
06-11-2017

The above comment is correct....for now. It will be changed to "error if < 4.1" (or 4.3) as part of JDK-8185923, which will bump the minimum version. Until then, the minimum remains at 3.0.
06-11-2017

> 1079 // Check for Gradle 4.3, error if < 3.0. I expect this comment needs to say something like "error if < 4.1" .. or 4.3 if you prefer. No need for a new webrev .. +1 assuming that is updated before the push
06-11-2017

Webrev: http://cr.openjdk.java.net/~kcr/8188654/webrev.00/ This just bumps the expected version number and removes an obsolete README file.
06-11-2017

Since the version number proposal has settled down, and the next version will be JDK 10, we can proceed with this. As of today, gradle 4.3 is the latest version so we will switch to that. Note that this will not change the minimum needed to build FX. That will be done later by JDK-8185923.
06-11-2017

Note that our build.gradle is already capable of using gradle 4.x -- see JDK-8185358.
04-10-2017