JDK-8181753 : Graal should support compiler directives
  • Type: Enhancement
  • Component: hotspot
  • Sub-Component: compiler
  • Affected Version: 10,12,13
  • Priority: P2
  • Status: Closed
  • Resolution: Won't Fix
  • Submitted: 2017-06-07
  • Updated: 2021-04-27
  • Resolved: 2021-04-27
Related Reports
Duplicate :  
JDK-8211823 - Parsing of compiler directives failed Could not load file: jcmd_directives.json
Duplicate :  
JDK-8211823 - Parsing of compiler directives failed Could not load file: jcmd_directives.json
Duplicate :  
JDK-8202666 - [GRAAL] compiler/compilercontrol/mixed/RandomCommandsTest.java test failed
Relates :  
JDK-8197446 - [Graal] compiler/compilercontrol/directives/LogTest.java fails with particular seed
Relates :  
JDK-8181831 - [Graal] compiler/whitebox tests fail to trigger OSR compilation
Sub Tasks
JDK-8220689 :  
problem list RandomCommandsTest in graal runs - Resolved
Description
compiler/compilercontrol/directives/ExcludeTest.java fails in case this test works with following directives.json file:

[{
  match: "compiler/compilercontrol/share/pool/sub/Klass.method()V", 
  c1: {
    Enable: true
  }, 
  c2: {
    Exclude: true
  }
}]
Comments
JEP 410 removed Graal from JDK.
27-04-2021
> Is there a bug to get compiler/compilercontrol/mixed/RandomCommandsTest.java problemlisted? got problem listed by JDK-8220689.
14-03-2019
Is there a bug to get compiler/compilercontrol/mixed/RandomCommandsTest.java problemlisted?
11-03-2019
Yes, we are :-)
27-02-2019
it seems we are missing compiler/compilercontrol/mixed/RandomCommandsTest.java test in the problem list.
20-01-2019
these tests were added to graal-specific problemlist by JDK-8197453 on Feb 27 2018: open/test/hotspot/jtreg/ProblemList-graal.txt 33:compiler/compilercontrol/commandfile/LogTest.java 8181753 generic-all 34:compiler/compilercontrol/commands/LogTest.java 8181753 generic-all 35:compiler/compilercontrol/directives/ExcludeTest.java 8181753 generic-all 36:compiler/compilercontrol/jcmd/AddExcludeTest.java 8181753 generic-all 37:compiler/compilercontrol/jcmd/AddLogTest.java 8181753 generic-all 38:compiler/compilercontrol/mixed/RandomValidCommandsTest.java 8181753 generic-all 65:compiler/compilercontrol/directives/LogTest.java 8181753 generic-all
20-01-2019
Should we stop running these compiler control tests with Graal for now?
15-10-2018
compiler/compilercontrol/mixed/RandomCommandsTest.java test failed -Djdk.test.lib.random.seed=-5741139894831852479
07-05-2018
compiler/compilercontrol/commandfile/LogTest.java fails with -Djdk.test.lib.random.seed=2077531880426638924
11-01-2018
I meant to use this RFE for the work. May be change Subject: Graal should support compiler directives. Note, we should not require that Graal supports all C2 directives as it is. It should only supports directives which make sense for Graal. We may even add new Graal specific directives in a future.
26-09-2017
[~kvn], should I proceed with creating such RFE or it has been already created?
26-09-2017
The comment from Vladimir: "It is missing functionality in Graal which would be nice to fix before we release Graal as JIT. I think we should assign such RFEs to Labs."
24-07-2017
Completely agree.
08-06-2017
[~neliasso], I don't think compiler control directives were ever supposed to work with Graal, right? As Igor pointed out, it's not clear why a c2 directive should affect Graal. In this case it's not a bug. I'm converting this to a RFE.
08-06-2017
general note, we need to figure out the best way for compile control and graal to work together. the need to clearify meaning of c1, c2 directives for cases when there is c1+graal and only graal.
07-06-2017
Steps to reproduce: > jtreg -jdk:HS10_JDK -vmoptions:"-Djdk.test.lib.random.seed=7996385739666060892 -XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCI -XX:+TieredCompilation -XX:+UseJVMCICompiler -Djvmci.compiler=graal" -dir:hotspot/test compiler/compilercontrol/directives/ExcludeTest.java
07-06-2017