JDK-8175085 : [REDO] G1 Needs pre barrier on dereference of weak JNI handles
  • Type: Bug
  • Component: hotspot
  • Sub-Component: gc
  • Affected Version: 9
  • Priority: P2
  • Status: Closed
  • Resolution: Fixed
  • OS: generic
  • CPU: generic
  • Submitted: 2017-02-16
  • Updated: 2017-03-16
  • Resolved: 2017-02-28
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 10 JDK 9
10Fixed 9 b161Fixed
Related Reports
Cloners :  
Relates :  
Sub Tasks
JDK-8175086 :  
Description
Mach 5 9-hs detected test failures due to this changeset:

Changeset: 3bc68ff68250
Author:    kbarrett
Date:      2017-02-15 22:19 -0500
URL: http://hg.openjdk.java.net/jdk9/hs/hotspot/rev/3bc68ff68250

8166188: G1 Needs pre barrier on dereference of weak JNI handles
Summary: Add low tag to jweaks and G1 barrier for jweak loads.
Reviewed-by: mgerdin, mdoerr, pliden, dlong, dcubed, coleenp, aph, tschatzl
Contributed-by: kim.barrett@oracle.com, martin.doerr@sap.com, volker.simonis@sap.com


which was pushed at 2028 PT/2128 MT/2328 ET so it did not make the 1900 PT
2017.02.15 nightly cutoff. Mach5's 14 test failures appear to all be in JDK
tests... Of course, we don't know if there will be additional failures in
JDK9-hs nightly testing.


So the good news: Mach5 detected this failure earlier than we would
have seen it with our normal HotSpot nightly! And with the email
notification to all of the folks involved, there has already been
eight follow-up messages (I don't count this one). 
Comments
JNI fast field getters need to mask out the jweak tag bit. Testing of fix in progress.
20-02-2017

Mikael volunteered to work on this while Kim is out.
17-02-2017

Moved 'integration_blocker' label to the backout bug. If we decide NOT to do the backout, then the 'integration_blocker' label has to be restored here.
16-02-2017

I'll pick up this fix while Kim is out. Basically the problem is that Kim's fix does not fix the fast jni getfield code path.
16-02-2017