JDK-8172237 : Fix errors in gradle dependencies
  • Type: Bug
  • Component: javafx
  • Sub-Component: build
  • Affected Version: 9
  • Priority: P2
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2017-01-04
  • Updated: 2017-02-09
  • Resolved: 2017-02-09
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 9
9Fixed
Related Reports
Blocks :  
Blocks :  
Duplicate :  
Duplicate :  
Relates :  
Description
There are errors in our gradle dependencies that result in missing deliverable files that happen randomly. Because of these missing deliverables - this is P2.

Once the JavaFX modules are built, successive incremental builds should be faster. Fixing dependencies and converting copy {} methods to type: Copy tasks should improve the up to date checks, and allow for quicker developer build resolution.

Comments
Changeset: 505e28f6b710 Author: ddhill Date: 2017-02-09 12:08 -0500 URL: http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/505e28f6b710 8172237: Fix errors in gradle dependencies Reviewed-by: kcr ! build.gradle ! gradle.properties.template
09-02-2017

Webrev looks good. All my testing looks good. There are a couple of follow-on optimizations that are possible, but they can be done in a subsequent JBS issue. The .7 version fixes the dependency errors and speeds up the build. +1
09-02-2017

+1. Looks good to me. Clean and incremental build works great on my Linux desktop.
08-02-2017

updated: http://jfx.us.oracle.com/shared-webrev/ddhill/8172237-jfx.8/
08-02-2017

The bug is here: - gradle $gradle_options sdk + gradle $gradle_options sdk jdkZip' There is a spurious single-quote at the end of that line.
08-02-2017

updated: http://cr.openjdk.java.net/~ddhill/8172237.7 adding the new jdkZip task
08-02-2017

updated: http://cr.openjdk.java.net/~ddhill/8172237.6
08-02-2017

Initial testing looks good. I will review the changes and do more testing, particularly for incremental builds.
07-02-2017

updated: http://cr.openjdk.java.net/~ddhill/8172237.4/
07-02-2017

updated: http://cr.openjdk.java.net/~ddhill/8172237.3
06-02-2017

A new webrev with Arun's changes as a base and mine piled on top: http://cr.openjdk.java.net/~ddhill/8172237/
03-02-2017

Updated webrev after [~kcr]'s change(JDK-8172522) : http://cr.openjdk.java.net/~arajkumar/8172237/webrev.01
18-01-2017

That is a different performance improvement. Dave: is there a bug already filed for speeding up the copy using a copy task?
04-01-2017

May be JDK-8169390?
04-01-2017

Dave is already working on a fix for this. I added him to the watch list so he can comment.
04-01-2017

webrev: http://cr.openjdk.java.net/~arajkumar/8172237/webrev Converted all problematic "copy method" to "copy tasks", with this no-op build takes just 2 to 3 secs in my dev machine. [~kcr], [~ddhill], Please take a look.
04-01-2017

buildModule task uses "copy" gradle method(not task) to copy class files into module directory. It should be converted to "copy task". "copy task" will reduce the time by doing a up-to date checking[1]. [1] http://stackoverflow.com/questions/10001795/conventional-way-of-copying-files-in-gradle-use-copy-task-or-copy-method
04-01-2017