JDK-8172069 : Modena sample: no response after clicking "Restart" button
  • Type: Bug
  • Component: javafx
  • Sub-Component: samples
  • Affected Version: OTN,8u60,9
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • OS: linux_ubuntu
  • CPU: x86
  • Submitted: 2016-12-28
  • Updated: 2020-01-31
  • Resolved: 2017-03-15
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 8 JDK 9
8u152Fixed 9Fixed
Related Reports
Relates :  
JDK-8094957 - Stop using deprecated builders in samples, toys, and other apps
Description
Product(s) tested: JDK8u121b13 (32bit) 
OS/architecture: Ubuntu16.04-x86 

Steps to reproduce: 
1. Install Test build JDK8u121b13
2. use test bundle:jdk-8u121-linux-i586-demos.tar.gz and extract to a folder<WS> 
3. Go to "demo/javafx_samples" directory in WS
4.run command: java -jar Modena.jar

The Actual Results:
There's no response after clicking "Restart" button and there's no exception thrown in terminal.Please refer to restart.png
Comments
Since this is a regression introduced in an 8 update release I will backport this to JDK 8u (after letting it bake in JDK 9 for a few days).
15-03-2017
Changeset: 0bd02dc65aed Author: kcr Date: 2017-03-15 15:52 -0700 URL: http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/0bd02dc65aed 8172069: Modena sample: no response after clicking "Restart" button Reviewed-by: ckyang
15-03-2017
+1
15-03-2017
Here is the proposed fix: diff --git a/apps/samples/Modena/src/main/java/modena/Modena.java b/apps/samples/Modena/src/main/java/modena/Modena.java --- a/apps/samples/Modena/src/main/java/modena/Modena.java +++ b/apps/samples/Modena/src/main/java/modena/Modena.java @@ -353,7 +353,7 @@ saveButton.setOnAction(saveBtnHandler); Button restartButton = new Button("Restart"); - retinaButton.setOnAction(event -> restart()); + restartButton.setOnAction(event -> restart()); ToolBar toolBar = new ToolBar(new HBox(modenaButton, caspianButton), reloadButton, rtlButton, /* embeddedPerformanceButton, new Separator(), */ retinaButton,
15-03-2017
Button restartButton = new Button("Restart"); retinaButton.setOnAction(event -> restart()); That second line should be: restartButton.setOnAction(event -> restart());
15-03-2017
This bug is caused by a typo in the test program introduced by the fix for JDK-8094957. The "Restart" button is no longer hooked up to anything. Instead, the functionality of the "@2x" button is mistakenly overwritten to do a restart. This bug was introduced in 8u60.
15-03-2017
Tested the scenario. No response from app on clicking Restart button. Not sure the expected behavior as well. Anyway keeping the bug as the behavior is not expected.
29-12-2016
These issue also happend on Mac10.11-x64 with JDK8u121b13-64bit and Win7-x86 with JDK8u121b13-32bit.
28-12-2016