JDK-8166663 : Simplify oops_on_card_seq_iterate_careful
  • Type: Sub-task
  • Component: hotspot
  • Sub-Component: gc
  • Affected Version: 9
  • Priority: P2
  • Status: Resolved
  • Resolution: Fixed
  • OS: generic
  • CPU: generic
  • Submitted: 2016-09-25
  • Updated: 2021-02-05
  • Resolved: 2016-09-26
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 8 JDK 9 Other
8u301Fixed 9 b140Fixed openjdk8u282Fixed
Related Reports
Blocks :  
Description
HeapRegion::oops_on_card_seq_iterate_careful has an interface and implementation that try to be (somewhat) general and support multiple caller contexts.  However, there is actually only one caller, G1RemSet::refine_card, which does not use or need that generality.

This unused generality makes the code harder to understand.  In particular, it makes the analysis needed to address JDK-8160369, due to the need to consider effectively unused code paths.

Comments
Fix Request [8u] Reviewing thread: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-November/012991.html
17-11-2020

The original patch for JDK-8166663 does not apply cleanly to jdk8u-dev due to path and code refactoring work in jdk9+. Also we need to wrap the error message using err_msg since we don't have the enhanced version of assert in jdk9+. 8u backport RFR thread: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-November/012991.html
16-11-2020