JDK-8165809 : Rework build to enable future jigsaw aware JDK9 build
  • Type: Bug
  • Component: javafx
  • Sub-Component: build
  • Priority: P2
  • Status: Resolved
  • Resolution: Fixed
  • OS: generic
  • CPU: generic
  • Submitted: 2016-09-11
  • Updated: 2016-09-16
  • Resolved: 2016-09-16
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 9
9Fixed
Related Reports
Blocks :  
Relates :  
Description
This is a baby step towards JDK-8161704.

The change consists of several related changes:
   1) clean up generated-source paths to allow for a future module-source-path that is cleaner (or at least shorter).
   2) remove dependencies on BUILD_SRC
       + move the JSLC sources out of buildSrc into the graphics module, though only as an intermediate build product.
   3) rework the complex graphics module build to create clearer dependancy graph that does not include buildSrc.
   4) set up graphics for a two pass java compile (first pass creates decora compiler required classes, the second generates the full module)
   5) address JDK-8091264 - Upgrade to newer version of antlr
Comments
Changeset: fa3d6410bf8e Author: ddhill Date: 2016-09-16 17:06 -0400 URL: http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/fa3d6410bf8e 8165809: Rework build to enable future jigsaw aware JDK9 build Reviewed-by: kcr
16-09-2016

@Kevin, Yes I renamed the test code for rev .2, we are not using it, but it was named wrong before. The antlr code is not in the modulesourcepath view, so I left it in generated-src for now. This might change slightly in the modular build, along with a bunch of other stuff.
16-09-2016

* There is one other change in the .2 version relative to .1. The .1 version renamed buildSrc/src/test/java/com to modules/javafx.graphics/src/test/decora/java/com The .2 version renames buildSrc/src/test/java/com to modules/javafx.graphics/src/test/jslc/com This is a fine change, if intentional, but I wanted to point out the difference. * One other thing I noticed is that the antlr-generated sources are still put into a directory named "generated-src". I don't know whether this matters: buildSrc/build.gradle: main.java.srcDirs = ["src/main/java", "$buildDir/generated-src/antlr"] buildSrc/build.gradle: String dest = "$buildDir/generated-src/antlr/com/sun/scenario/effect/compiler" Anyway, I'm happy with the fix if you are. All my testing looks good. +1
16-09-2016

reworked to preserve the moves, no other changes: http://cr.openjdk.java.net/~ddhill/8165809.2
15-09-2016

The webrev doesn't show the moved files as renames in hg. This will cause the history to be lost.
15-09-2016

http://cr.openjdk.java.net/~ddhill/8165809.1
11-09-2016