JDK-8163816 : JShell tests: jdk/jshell/ExternalEditorTest.java -- unexpected results EditorTestBase.testEditClass1() and .testEditMethod1()
  • Type: Bug
  • Component: tools
  • Sub-Component: jshell
  • Affected Version: 9
  • Priority: P4
  • Status: Closed
  • Resolution: Fixed
  • Submitted: 2016-08-10
  • Updated: 2017-02-10
  • Resolved: 2016-11-16
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 9
9 b147Fixed
Related Reports
Relates :  
JDK-8158197 - jshell tool: testHeadlessEditPad hangs
Relates :  
JDK-8159229 - JShell test: jdk/jshell/ExternalEditorTest.java testRemoveTempFile(): failure
Relates :  
JDK-8163817 - JShell tests: disable minor failing editor tool cases: 8161276, 8163816, 8159229
Description
test EditorTestBase.testEditClass1(): failure
java.lang.AssertionError: command expected [] but found [|  modified class A]
	at org.testng.Assert.fail(Assert.java:94)
	at org.testng.Assert.failNotEquals(Assert.java:494)
	at org.testng.Assert.assertEquals(Assert.java:123)
	at org.testng.Assert.assertEquals(Assert.java:176)
	at EditorTestBase.lambda$assertEditOutput$3(EditorTestBase.java:68)
	at ExternalEditorTest.assertEdit(ExternalEditorTest.java:174)
	at EditorTestBase.assertEditOutput(EditorTestBase.java:60)
	at EditorTestBase.assertEditOutput(EditorTestBase.java:68)
	at EditorTestBase.lambda$testEditClass1$23(EditorTestBase.java:132)
	at ReplToolTesting$PromptedCommandOutputStream.write(ReplToolTesting.java:766)
	at ReplToolTesting$PromptedCommandOutputStream.write(ReplToolTesting.java:782)
	at java.io.PrintStream.write(java.base@9-ea/PrintStream.java:480)
	at sun.nio.cs.StreamEncoder.writeBytes(java.base@9-ea/StreamEncoder.java:233)
	at sun.nio.cs.StreamEncoder.implFlushBuffer(java.base@9-ea/StreamEncoder.java:312)
	at sun.nio.cs.StreamEncoder.implFlush(java.base@9-ea/StreamEncoder.java:316)
	at sun.nio.cs.StreamEncoder.flush(java.base@9-ea/StreamEncoder.java:153)
	at java.io.OutputStreamWriter.flush(java.base@9-ea/OutputStreamWriter.java:262)
	at jdk.internal.jline.console.ConsoleReader.readLine(jdk.internal.le@9-ea/ConsoleReader.java:2336)
	at jdk.internal.jline.console.ConsoleReader.readLine(jdk.internal.le@9-ea/ConsoleReader.java:2277)
	at jdk.internal.jshell.tool.ConsoleIOContext.readLine(jdk.jshell@9-ea/ConsoleIOContext.java:176)
	at jdk.internal.jshell.tool.JShellTool.run(jdk.jshell@9-ea/JShellTool.java:747)
	at jdk.internal.jshell.tool.JShellTool.start(jdk.jshell@9-ea/JShellTool.java:504)
	at jdk.internal.jshell.tool.JShellTool.start(jdk.jshell@9-ea/JShellTool.java:462)
	at ReplToolTesting.testRaw(ReplToolTesting.java:257)
	at ReplToolTesting.test(ReplToolTesting.java:213)
	at ReplToolTesting.test(ReplToolTesting.java:201)
	at EditorTestBase.testEditor(EditorTestBase.java:49)
	at ExternalEditorTest.testEditor(ExternalEditorTest.java:119)
	at EditorTestBase.testEditor(EditorTestBase.java:45)
	at EditorTestBase.testEditClass1(EditorTestBase.java:130)
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(java.base@9-ea/Native Method)
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(java.base@9-ea/NativeMethodAccessorImpl.java:62)
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(java.base@9-ea/DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(java.base@9-ea/Method.java:535)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:84)
	at org.testng.internal.Invoker.invokeMethod(Invoker.java:714)
	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:901)
	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1231)
	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127)
	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
	at org.testng.TestRunner.privateRun(TestRunner.java:767)
	at org.testng.TestRunner.run(TestRunner.java:617)
	at org.testng.SuiteRunner.runTest(SuiteRunner.java:334)
	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:329)
	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:291)
	at org.testng.SuiteRunner.run(SuiteRunner.java:240)
	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1224)
	at org.testng.TestNG.runSuitesLocally(TestNG.java:1149)
	at org.testng.TestNG.run(TestNG.java:1057)
	at com.sun.javatest.regtest.TestNGAction$TestNGRunner.main(TestNGAction.java:220)
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(java.base@9-ea/Native Method)
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(java.base@9-ea/NativeMethodAccessorImpl.java:62)
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(java.base@9-ea/DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(java.base@9-ea/Method.java:535)
	at com.sun.javatest.regtest.agent.MainActionHelper$SameVMRunnable.run(MainActionHelper.java:226)
	at java.lang.Thread.run(java.base@9-ea/Thread.java:843)
config ReplToolTesting.setUp(): success
test EditorTestBase.testEditClass2(): success
config ReplToolTesting.setUp(): success
test EditorTestBase.testEditMethod1(): failure
java.lang.AssertionError: command expected [] but found [|  modified method f()]
	at org.testng.Assert.fail(Assert.java:94)
	at org.testng.Assert.failNotEquals(Assert.java:494)
	at org.testng.Assert.assertEquals(Assert.java:123)
	at org.testng.Assert.assertEquals(Assert.java:176)
	at EditorTestBase.lambda$assertEditOutput$3(EditorTestBase.java:68)
	at ExternalEditorTest.assertEdit(ExternalEditorTest.java:174)
	at EditorTestBase.assertEditOutput(EditorTestBase.java:60)
	at EditorTestBase.assertEditOutput(EditorTestBase.java:68)
	at EditorTestBase.lambda$testEditMethod1$35(EditorTestBase.java:170)
	at ReplToolTesting$PromptedCommandOutputStream.write(ReplToolTesting.java:766)
	at ReplToolTesting$PromptedCommandOutputStream.write(ReplToolTesting.java:782)
	at java.io.PrintStream.write(java.base@9-ea/PrintStream.java:480)
	at sun.nio.cs.StreamEncoder.writeBytes(java.base@9-ea/StreamEncoder.java:233)
	at sun.nio.cs.StreamEncoder.implFlushBuffer(java.base@9-ea/StreamEncoder.java:312)
	at sun.nio.cs.StreamEncoder.implFlush(java.base@9-ea/StreamEncoder.java:316)
	at sun.nio.cs.StreamEncoder.flush(java.base@9-ea/StreamEncoder.java:153)
	at java.io.OutputStreamWriter.flush(java.base@9-ea/OutputStreamWriter.java:262)
	at jdk.internal.jline.console.ConsoleReader.readLine(jdk.internal.le@9-ea/ConsoleReader.java:2336)
	at jdk.internal.jline.console.ConsoleReader.readLine(jdk.internal.le@9-ea/ConsoleReader.java:2277)
	at jdk.internal.jshell.tool.ConsoleIOContext.readLine(jdk.jshell@9-ea/ConsoleIOContext.java:176)
	at jdk.internal.jshell.tool.JShellTool.run(jdk.jshell@9-ea/JShellTool.java:747)
	at jdk.internal.jshell.tool.JShellTool.start(jdk.jshell@9-ea/JShellTool.java:504)
	at jdk.internal.jshell.tool.JShellTool.start(jdk.jshell@9-ea/JShellTool.java:462)
	at ReplToolTesting.testRaw(ReplToolTesting.java:257)
	at ReplToolTesting.test(ReplToolTesting.java:213)
	at ReplToolTesting.test(ReplToolTesting.java:201)
	at EditorTestBase.testEditor(EditorTestBase.java:49)
	at ExternalEditorTest.testEditor(ExternalEditorTest.java:119)
	at EditorTestBase.testEditor(EditorTestBase.java:45)
	at EditorTestBase.testEditMethod1(EditorTestBase.java:168)
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(java.base@9-ea/Native Method)
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(java.base@9-ea/NativeMethodAccessorImpl.java:62)
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(java.base@9-ea/DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(java.base@9-ea/Method.java:535)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:84)
	at org.testng.internal.Invoker.invokeMethod(Invoker.java:714)
	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:901)
	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1231)
	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127)
	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
	at org.testng.TestRunner.privateRun(TestRunner.java:767)
	at org.testng.TestRunner.run(TestRunner.java:617)
	at org.testng.SuiteRunner.runTest(SuiteRunner.java:334)
	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:329)
	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:291)
	at org.testng.SuiteRunner.run(SuiteRunner.java:240)
	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1224)
	at org.testng.TestNG.runSuitesLocally(TestNG.java:1149)
	at org.testng.TestNG.run(TestNG.java:1057)
	at com.sun.javatest.regtest.TestNGAction$TestNGRunner.main(TestNGAction.java:220)
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(java.base@9-ea/Native Method)
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(java.base@9-ea/NativeMethodAccessorImpl.java:62)
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(java.base@9-ea/DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(java.base@9-ea/Method.java:535)
	at com.sun.javatest.regtest.agent.MainActionHelper$SameVMRunnable.run(MainActionHelper.java:226)
	at java.lang.Thread.run(java.base@9-ea/Thread.java:843)
Comments
May be related test harness issues
27-10-2016
Not longer causing test failures (disabled). So lower priority.
10-08-2016
Only seen failing on Windows platforms. Entered text not recognized as equivalent. May be related to newline trimming. Should maybe use String.trim().
10-08-2016