JDK-8162883 : ESC button fails to cancel Dialog
  • Type: Bug
  • Component: javafx
  • Sub-Component: controls
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2016-08-01
  • Updated: 2016-08-02
  • Resolved: 2016-08-02
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 9
9Fixed
Related Reports
Relates :  
JDK-8090322 - Need new tree visible property in Node that consider Scene and Stage visibility
Description
To reproduce this:

1. Run the HelloAlert example
2. Press on any of the following to bring up the corresponding dialog: "Toggle color", "Question", or "Name"
3. Press the ESC key
Expected behavior: dialog is canceled
4. BUG: Nothing happens
Comments
Changeset: 4b8a299cbbbc Author: ckyang Date: 2016-08-02 13:14 -0700 URL: http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/4b8a299cbbbc
02-08-2016
+1
02-08-2016
The fix is basically to revert the change to ButtonSkin.java which it should be using isTreeVisible() logic instead of isTreeShowing(): http://cr.openjdk.java.net/~ckyang/JDK-8162883/webrev.00/
02-08-2016
Looks like this is a regression introduced by the fix for JDK-8090322. I bisected it and discovered this: The first bad revision is: changeset: 9890:4b60077e4d1b user: ckyang date: Wed Jul 06 13:43:05 2016 -0700 summary: 8090322: Need new tree visible property in Node that consider Scene and Stage visibility
01-08-2016