JDK-8159726 : Cleanup whitespace and file permission in tests repo
  • Type: Bug
  • Component: javafx
  • Sub-Component: other
  • Affected Version: 8,9
  • Priority: P2
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2016-06-16
  • Updated: 2020-01-31
  • Resolved: 2016-08-15
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 8 JDK 9
8u152Fixed 9Fixed
Related Reports
Relates :  
JDK-8158784 - [TEST BUG] Need test for JDK-8157398
Relates :  
JDK-8147967 - Cleanup whitespace and file permission
Description
As a follow-up fix to JDK-8147967 we need to cleanup the whitespace and file permission in the openjfx tests repo for 8u and 9.
Comments
8u-dev applies successfully now and is ok be pushed.
21-08-2016
Fix was pushed to 9-dev. Awaiting review for 8u-dev.
15-08-2016
Changeset: e5d3d8a7cd71 Author: kcr Date: 2016-08-15 07:34 -0700 URL: http://hg.openjdk.java.net/openjfx/9-dev/tests/rev/e5d3d8a7cd71 8159726: Cleanup whitespace and file permission in tests repo Reviewed-by: arusakov
15-08-2016
Here is the 8u-dev webrev: http://cr.openjdk.java.net/~kcr/8159726/webrev-8.01/
12-08-2016
I know that 8u-dev requires a separate patch. That's what I said above. I generated the webrev, but did not upload it. I can upload the webrev if you like.
12-08-2016
No, 8u-dev requires separate patch because 8u-dev/tests contains test for JDK-8158784 and hg fails to apply patch to ControlsTests/test/javafx/scene/control/test/treetable/CommonTreeTableTest.java. Patch for 9-dev/tests is fine.
11-08-2016
Webrev: http://cr.openjdk.java.net/~kcr/8159726/webrev-9.01/ This proposed fix was done by running the following script on Linux from the 9-dev/tests repo: ../rt/tools/scripts/checkWhiteSpace -F -a -x I manually reverted the changes to one file: functional/FxmlTests/src/test/fxmltests/resources/include3.fxml because it is a UTF-16 encoded file (intentionally so as part of a test for UTF-16). Fortunately jcheck doesn't care about .fxml files, so this won't block enabling jcheck. The only down-side of not fixing this one file is that checkWhiteSpace will always complain about it. That shouldn't present a problem as long as we are aware of it. Btw, the 8u-dev patch was generated using the same script. I didn't post the 8u-dev webrev, since it seems redundant.
08-08-2016