JDK-8158109 : Compilation error in FX media native code with VS 2010
  • Type: Bug
  • Component: javafx
  • Sub-Component: media
  • Affected Version: 8u102,9
  • Priority: P4
  • Status: Closed
  • Resolution: Won't Fix
  • OS: windows
  • CPU: x86_64
  • Submitted: 2016-05-28
  • Updated: 2024-11-23
  • Resolved: 2024-11-23
Related Reports
Blocks :  
JDK-8344728 - ☂ Gradle build modernization
Relates :  
JDK-8153534 - Intermittent hang in GSTMedia.gstDispose
Description
For FX 8u and 9 we use VS 2013 SP4, but it is a goal to keep the code buildable on VS 2010. The recent fix for JDK-8153534 causes a compilation error on VS 2010. It would be good to fix this if at all possible (it isn't an absolute requirement since media is not compiled by default).
Comments
We currently build JavaFX with Visual Studio 2022. We require at least VS 2017 for everything except WebKit (which needs VS 2022), so this bug is no longer relevant.
23-11-2024
The Rampdown phase start [1] milestone is approaching, it means we are not targeting "9" to fix P4s anymore, unless the fix is ready and not risky, safe enough do not introduce P2-P3 regressions; if this is a case you can retarget back to "9" right before the push the reviewed code to repo. [1] http://openjdk.java.net/projects/jdk8/milestones#Rampdown_start
01-09-2016
Yes, you just need to unset VS120COMNTOOLS, make sure that VS100COMNTOOLS is set. You should also "rm -rf build" in the rt directory, since our gradle build script caches your VS environment in a properties file in the build directory (gradle clean should remove it, but sometimes doesn't).
01-06-2016
It should be very easy to fix by moving "GstStateChangeReturn ret" declaration before actual code. Do you know how to force VS 2010 if I have both installed?
31-05-2016
Here is the error message I get: ../../../gstreamer-lite/gstreamer/plugins/elements/gstqueue.c(1696) : error C2143: syntax error : missing ';' before 'type' ../../../gstreamer-lite/gstreamer/plugins/elements/gstqueue.c(1698) : error C2065: 'ret' : undeclared identifier ../../../gstreamer-lite/gstreamer/plugins/elements/gstqueue.c(1699) : error C2065: 'ret' : undeclared identifier ../../../gstreamer-lite/gstreamer/plugins/elements/gstqueue.c(1712) : error C2065: 'ret' : undeclared identifier make[1]: *** [9-dev/rt/modules/media/build/native/win/Release/obj/gstreamer-lite/gstreamer/plugins/elements/gstqueue.obj] Error 2
28-05-2016