JDK-8157384 : Update java-wrappers for WebKit generated classes following WebKit update
  • Type: Bug
  • Component: javafx
  • Sub-Component: web
  • Affected Version: 8u112,9
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2016-05-20
  • Updated: 2020-01-31
  • Resolved: 2016-06-17
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 8 JDK 9
8u112Fixed 9Fixed
Related Reports
Relates :  
JDK-8172361 - Update java-wrappers for WebKit generated classes following WebKit update
Relates :  
JDK-8156698 - Update to newer version of WebKit
Relates :  
JDK-8090062 - Update java-wrappers for WebKit generated classes following WebKit update
Description
The com.sun.webkit.dom Java wrappers, which are generated by the native WebKit build, are also checked into modules/web/src/main/java-wrappers/com/sun/webkit/dom so that the Java code can build without requiring a build of the native WebKit.

These files need to be refreshed following the WebKit update in JDK-8156698, since the updated webkit has changed the generated wrappers.

See JDK-8090062 for the last time this was done. The basic recipe is:

1. Build FX 9-dev with -PCOMPILE_WEBKIT=true

2. Copy the .java files from modules/web/build/win/Release/DerivedSources/WebCore/nativeJava/java/com/sun/webkit/dom/*.java to modules/web/src/main/java-wrappers/com/sun/webkit/dom/

3. Build FX 9-dev again, this time with -PCOMPILE_WEBKIT=false (as a sanity test to make sure it still builds).

4. Create a webrev with the changes for the java-wrappers
Comments
changeset: ab36b2ecae25 user: arajkumar date: Fri Jun 17 09:27:27 2016 +0100 8157384: Update java-wrappers for WebKit generated classes following WebKit update Reviewed-by: kcr, ghb URL: http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/ab36b2ecae25
17-06-2016
+1
17-06-2016
Addressed Kevin's review comment. Please take a look. http://cr.openjdk.java.net/~arajkumar/8157384/webrev.01
16-06-2016
Modified and added classes look good. The only thing I noticed is that the following file currently in java-wrappers is no longer generated, so is unneeded: modules/web/src/main/java-wrappers/com/sun/webkit/dom/NotationImpl.java
15-06-2016
http://cr.openjdk.java.net/~arajkumar/8157384/webrev.00
15-06-2016