JDK-8157002 : Toggle gtk version if SWT used via FXCanvas
Type:Bug
Component:javafx
Sub-Component:window-toolkit
Priority:P2
Status:Resolved
Resolution:Fixed
Submitted:2016-05-15
Updated:2016-12-15
Resolved:2016-12-15
The Version table provides details related to the release that this issue/RFE will be addressed.
Unresolved : Release in which this issue/RFE will be addressed. Resolved: Release in which this issue/RFE has been resolved. Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.
Changeset: bd5aa92d106f
Author: ssadetsky
Date: 2016-12-15 17:47 -0500
URL: http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/bd5aa92d106f
8157002: Toggle gtk version if SWT used via FXCanvas
Reviewed-by: kcr, ddhill
15-12-2016
+1
15-12-2016
+1
14-12-2016
Like the new webrev better :-)
23-11-2016
The webrev was updated: http://cr.openjdk.java.net/~ssadetsky/8157002/webrev.01/
23-11-2016
Actually, I do have one comment on the code. It might be cleaner to move the checking code from GtkPlatformFactory to the static block of GtkApplication (before the native library is loaded). This is just a suggestion, though. It is OK either way.
22-11-2016
Looks good. I tested it and it works as expected.
+1
22-11-2016
I will review it shortly (I'd like to run a quick test).
This bug is filed for the special case of detecting which GTK version is being used when SWT is loaded prior to initializing FX. The more general bug is tracked by JDK-8156491. If that bug can be fixed, then it should take care of this case. Otherwise we should look at implementing something that at least works for SWT.