JDK-8153655 : TESTBUG: intrinsics tests must be updated to enable diagnostic options
  • Type: Bug
  • Component: hotspot
  • Sub-Component: compiler
  • Affected Version: 9
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2016-04-06
  • Updated: 2016-05-26
  • Resolved: 2016-05-09
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 9
9 b120Fixed
Related Reports
Relates :  
JDK-8145348 - Make intrinsics flags diagnostic
Relates :  
JDK-8153783 - UnlockDiagnosticVMOptions should not be trueInDebug
Sub Tasks
JDK-8153816 :  
[BACKOUT] Make intrinsics flags diagnostic - Resolved
Description
After JDK-8145348 fix, at least 5 tests started to fail. Tests needs to be updated and enable diagnostic vm options.

tests:
compiler/cpuflags/TestAESIntrinsicsOnUnsupportedConfig.java
compiler/intrinsics/sha/cli/TestUseSHA1IntrinsicsOptionOnUnsupportedCPU.java
compiler/intrinsics/sha/cli/TestUseSHA256IntrinsicsOptionOnUnsupportedCPU.java
compiler/intrinsics/sha/cli/TestUseSHA512IntrinsicsOptionOnUnsupportedCPU.java
compiler/intrinsics/sha/cli/TestUseSHAOptionOnUnsupportedCPU.java
Comments
revised <webrev.01> : http://cr.openjdk.java.net/~rraghavan/8153655/webrev.01/ RFR: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-May/022817.html
05-05-2016
RFR : http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2016-April/022642.html
27-04-2016
1. Generated 8153655/webrev.00 to be send for open review. http://cr.openjdk.java.net/~rraghavan/8153655/webrev.00/ This 8153655/webrev.00 re-includes earlier backed out, same JDK-8145348 changes (Make intrinsics flags diagnostic) and also additional fixes in failing intrinsic tests. 2. Checked all the usages of changed intrinsic flags in tests and found JDK-8153655 type test failure issue (after initial JDK-8145348 fix) is present only for following tests - a. UseAESIntrinsics test (compiler/cpuflags/TestAESIntrinsicsOnUnsupportedConfig.java) b. UseSHA* tests (at compiler/intrinsics/sha/cli/) 3. >> " .. investigate why these tests and tests *OnSupportedCPU*, *OnSupportedConfig* does not fail.." - 'TestAESIntrinsicsOnSupportedConfig.java' is not run at present, ignored quarantined for JDK-8146128/JDK-8146129. - 'compiler/intrinsics/sha/cli/TestUseSHA*OptionOnSupportedCPU' do fail for SPARC with product builds (same 8153655 issue). ('TestUseSHA*OptionOnSupportedCPU' for aarch64, x64 passes by just 'Skipping due to predicate failure'. This is expected correct behavior and so 8153655 issue is not applicable for these targets.) 4. Summary of 8153655/webrev.00 changes. - Includes earlier backed out, same JDK-8145348 changes: src/share/vm/c1/c1_globals.hpp src/share/vm/opto/c2_globals.hpp src/share/vm/runtime/globals.hpp test/compiler/intrinsics/muladd/TestMulAdd.java test/compiler/runtime/6859338/Test6859338.java - 'test/compiler/cpuflags/AESIntrinsicsBase.java' Options were passed in wrong order. Changes done so that 'UnlockDiagnosticVMOptions' option precedes the diagnostic flags. - 'test/compiler/intrinsics/sha/cli/*' (UseSHA* tests) 'UnlockDiagnosticVMOptions' option was not getting passed. Added support to precede intrinsic flag usages with explicit 'UnlockDiagnosticVMOptions'. 5. No issues found with testing done using product builds with proposed changes (hotspot/test/compiler/cpuflags/, hotspot/test/compiler/intrinsics/, hotspot/test/compiler/runtime/6859338/Test6859338.java) Complete pre-integration testing using product builds is in progress.
27-04-2016
short update - - UseAESIntrinsics test failure - due to wrong order of the options. 'UnlockDiagnosticVMOptions' option must precede. (TestAESIntrinsicsOnSupportedConfig.java is not run, ignored quarantined for 8146128) - UseSHA* tests failure - 'UnlockDiagnosticVMOptions' option not passed. - In progress - Proper fix, checking all other related intrinsic tests, checking 'OnSupportedCPU*/Config*' tests
20-04-2016
The problem is that these tests fork an other VM with intrinsic options but do not pass UnlockDiagnosticVMOptions to new VM. Rahul, please, also investigate why these tests and tests *OnSupportedCPU*, *OnSupportedConfig* does not fail with product VM on x86 or SPARC. They should fail too.
08-04-2016
Tests failed running product VM: stderr: [Error: VM option 'UseAESIntrinsics' is diagnostic and must be enabled via -XX:+UnlockDiagnosticVMOptions. Error: The unlock option must precede 'UseAESIntrinsics'. Error: Could not create the Java Virtual Machine. Error: A fatal exception has occurred. Program will exit. ]
08-04-2016
Changed this to a P1 since Alejandro cannot take this week's snapshot with these failures in place. Update: just added Alejandro this bug...
07-04-2016