JDK-8148489 : conditional execution of unstable tests
  • Type: Bug
  • Component: javafx
  • Sub-Component: other
  • Affected Version: 9
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2016-01-28
  • Updated: 2019-06-12
  • Resolved: 2016-01-29
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 8 JDK 9
8u231Fixed 9Fixed
Related Reports
Relates :  
JDK-8145203 - Refactor systemTests for clear separation of tests
Description
The windowCloseTest in the test.renderlock.RenderLock1Test unit test fails on our nightly unit test machine.

java.lang.AssertionError: Timeout waiting for alert to be hidden
    at org.junit.Assert.fail(Assert.java:91)
    at test.renderlock.RenderLockCommon.doWindowCloseTest(RenderLockCommon.java:175)
    at test.renderlock.RenderLock1Test.windowCloseTest(RenderLock1Test.java:33)

We had previously qualified this test to run only when the robot tests are run -- that is, when USE_ROBOT is set to true -- but the recent refactoring done for JDK-8145203 has put all robot tests in a separate package hierarchy, and since this isn't a robot test it is no longer excluded.

We will need some other means to exclude this test (or add it back in as a special case test that is also qualified by USE_ROBOT, but that is a bit of a hack).

The means chosen is a system property passed from gradle to all of the test bundles:
    systemProperty 'unstable.test', IS_UNSTABLE_TEST
toggled by gradle -PUNSTABLE_TEST=true

and used as a toggle in test classes:
    assumeTrue(Boolean.getBoolean("unstable.test"));
Comments
This is OpenJFX issue, not the OpenJDK one, putting openjdk-na to get it off the backporting radar.
12-06-2019
Changeset: 396ef46b3445 Author: ddhill Date: 2016-01-29 13:04 -0500 URL: http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/396ef46b3445 8148489: conditional execution of unstable tests Reviewed-by: kcr
29-01-2016
+1
29-01-2016
http://cr.openjdk.java.net/~ddhill/8148489/ Tested with the temp addition of: @Test public void unstable_test_check() { assumeTrue(Boolean.getBoolean("unstable.test")); assertTrue(false); } ignored by default, failed as expected with -PUNSTABLE_TEST=true
29-01-2016