JDK-8145858 : Refactor fxml module for clear separation of tests
  • Type: Bug
  • Component: javafx
  • Sub-Component: fxml
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2015-12-19
  • Updated: 2015-12-21
  • Resolved: 2015-12-21
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 9
9Fixed
Related Reports
Blocks :  
Description
The JavaFX unit tests have relied on a "mixed" class path for testing, needing to run on the application classpath to access Junit as well the test classes. This is not how Javafx runs in normal circumstances, as it is normally on the extension class loader.

We need to refactor these test:
    the "white box", classes that must reside in certain classes for protected class access
    the "black box": classes that can operate from outside the javafx package structure

This will require adding some "shims" in the white box, to allow the black box tests to operate.
All Junit tests must be in the black box.

All black box tests will be refactored into a package tests.*

This refactoring affects modularization efforts in JDK 9 
Comments
Changeset: 0ee0788b8151 Author: ddhill Date: 2015-12-21 16:28 -0500 URL: http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/0ee0788b8151 8145858: Refactor fxml module for clear separation of tests Reviewed-by: kcr, jgiles
21-12-2015

Dave sent a patch which I applied and tested on Windows. +1
21-12-2015

The changes look fine, but the changeset patch in the webrev is empty so I cannot apply and test it.
21-12-2015

+1
20-12-2015

http://cr.openjdk.java.net/~ddhill/8145858/
19-12-2015