Bug ID: JDK-8145260 To bring j.u.z.ZipFile's native implementation to Java to remove the expensive jni cost and mmap crash risk [2]

Versions (Unresolved/Resolved/Fixed)

The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.

JDK 8	JDK 9
8-poolUnresolved	9 b99Fixed

The current j.u.z.ZipFile has following major issues:

(1) Its ZIP file format support code is in native C code (shared with the VM via ZipFile.c -> zip_util.c). Any entry lookup, creation requires multiple round-trip of expensive jni invocations.

(2) The current native C implementation code uses mmap to map in the central directory table appears to be a big risk of vm crash when the underlying jar file gets overwritten with new contents while it is still being used by other ZipFile.

(3) The use of "filename + lastModified()" cache (at native) appears to be broken if the timestamp is in low resolution,and/or the file is being overwritten.

The clean solution here is to bring the ZIP format support code from native to Java to remove the jni invocation cost and the mmap risk. Also to use the fileKey and lastModified from java.nio.file.attribute.BasicFileAttributes to have better cache matching key. 

--

The first try of this enhancement JDK-8142508 failed (which causes jtreg fails in -avm mode for those testng tests). This issue is used to integrate the updated change for JDK-8142508

We should consider this for backporting once it's had a few weeks/months of testing.
08-01-2016
review thread : http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-December/037543.html
08-01-2016
URL: http://hg.openjdk.java.net/jdk9/jdk9/jdk/rev/d85c42d008a9 User: lana Date: 2015-12-23 23:04:19 +0000
23-12-2015
URL: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/d85c42d008a9 User: sherman Date: 2015-12-14 17:27:33 +0000
14-12-2015

Duplicate :	JDK-8031691 - Crash in Zipfile.GetEntry
Duplicate :	JDK-8152661 - Crash in memmove when called from libzip
Relates :	JDK-4347142 - Need method to set Password protection to Zip entries
Relates :	JDK-8334048 - -Xbootclasspath can not read some ZIP64 zip files
Relates :	JDK-8226530 - ZipFile reads wrong entry size from ZIP64 entries
Relates :	JDK-8336843 - Deprecate java.util.zip.ZipError for removal
Relates :	JDK-8242842 - Avoid reallocating name when checking for trailing slash in ZipFile.getEntryPos
Relates :	JDK-8142508 - To bring j.u.z.ZipFile's native implementation to Java to remove the expensive jni cost and mmap crash risk
Relates :	JDK-8146431 - j.u.z.ZipFile.getEntry("") throws AIOOBE
Relates :	JDK-8170831 - ZipFile implementation no longer caches the last accessed entry/pos
Relates :	JDK-8144958 - changes by JDK-8142508 seems to have broken jtreg
Relates :	JDK-8345835 - Optimize central directory reading in java.util.zip.ZipFile