JDK-8139326 : [TEST] Unit tests for JFXPanel with security manager don't detect errors
  • Type: Bug
  • Component: javafx
  • Sub-Component: other
  • Affected Version: 8u20
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2015-10-09
  • Updated: 2020-01-31
  • Resolved: 2015-10-09
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 8 JDK 9
8u102Fixed 9Fixed
Related Reports
Blocks :  
JDK-8139317 - [Mac] SecurityException when constructing WebView from JFXPanel application
Relates :  
JDK-8139317 - [Mac] SecurityException when constructing WebView from JFXPanel application
Relates :  
JDK-8097417 - Create regression tests that run JavaFX apps with a security manager
Description
The JFXPanel-based unit tests created to address JDK-8097417 don't detect and report exceptions that occur during the creation of the JavaFX scene. If you run the test case you can visually see that it doesn't render correctly, but the test passes anyway. 

See JDK-8139317 for an example of a bug that occurs on the Mac but went undetected due to this test bug.

We need to fix the test bug so that this and any possible future errors are detected.

I will push a separate fix for the test itself to address this bug. Until JDK-8139317 is fixed, the JFXPanel test needs to be skipped on Mac.
Comments
+1. I have verified that it looks good and passed Mac clean build and test run.
19-04-2016
Now that I am ready to work on JDK-8139317 I will push the fix for this test to JDK 8u. The patch imports cleanly into 8u-dev; I verified that if I enable the test case that fails due to JDK-8139317 it will correctly detect and report the error, whereas it does not report the error without the test fix.
19-04-2016
This test fix will need to be backported to 8 in order to test the fix for JDK-8139317, the latter of which is a WebView bug and will be backported as a matter of course.
09-10-2015
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/924279a338d6
09-10-2015
+1. Looks good to me.
09-10-2015
http://cr.openjdk.java.net/~kcr/8139326/webrev.00/ The test incorrectly checked to see whether there was an exception creating the FX scene before such an error would have been detected. The fix is to verify the successful creation of the FX scene, and check for and report any exceptions when the text program finishes.
09-10-2015