JDK-8137308 : Refactor/fix LabeledImpl control tests
  • Type: Bug
  • Component: javafx
  • Sub-Component: controls
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2015-09-28
  • Updated: 2015-09-29
  • Resolved: 2015-09-29
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 9
9Fixed
Related Reports
Blocks :  
JDK-8131896 - Run gradle test tasks using a Jigsaw (jake) build
Description
LabeledImplTest needs changes is locating resources.

LabeledImplTestOther should be LabeledImplOtherTest so it gets run.
Comments
Changeset: 6dcc449dfbf9 Author: ddhill Date: 2015-09-29 17:02 -0400 URL: http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/6dcc449dfbf9 8137308: Refactor/fix LabeledImpl control tests Reviewed-by: jgiles
29-09-2015
+1
29-09-2015
updated webrev: http://cr.openjdk.java.net/~ddhill/8137308.1/
29-09-2015
I had a similar thought myself when I copied it over, but ended up maintaining the path. I will happily move it to test.com.sun.javafx.scene.control. You ok with it otherwise ?
29-09-2015
I'm (still) confused: you're adding the center-btn.png image into the controls module test resources (which is good), but you're placing it in a package that is not part of the controls module (test.javafx.scene.layout). I would have assumed it would be in test.com.sun.javafx.scene.control?
28-09-2015
webrev: http://cr.openjdk.java.net/~ddhill/8137308/
28-09-2015