JDK-8136656 : Check in blessed-modifier-order.sh
  • Type: New Feature
  • Component: core-libs
  • Priority: P2
  • Status: Resolved
  • Resolution: Fixed
  • OS: generic
  • CPU: generic
  • Fix Versions: 9
  • Submitted: 2015-09-16
  • Updated: 2015-11-09
  • Resolved: 2015-09-17
Related Reports
Relates :  
JDK-8136583 - Core libraries should use blessed modifier order
Description
blessed-modifier-order.sh was used to do a major code cleanup in JDK-8136583 but it is useful for future cleanups and should be checked in, and productionized a wee bit.

This version is "bolder" in that it tries to modify javadoc comments as well
Comments
I ran this over the entire jdk repo; 1532 files modified; seems to work fine.
16-09-2015
http://cr.openjdk.java.net/~martin/webrevs/openjdk9/blessed-modifier-order.sh/
16-09-2015
I ran this on the entire jdk repo and then checked for munged javadoc comments, which are all "good" changes we want to keep, even though it makes the script a little riskier. - * synchronized static method of that class. + * static synchronized method of that class. - * abstract protected methods defined in this class need not synchronize + * protected abstract methods defined in this class need not synchronize - * final static ImageIcon longIcon = new ImageIcon("long.gif"); - * final static ImageIcon shortIcon = new ImageIcon("short.gif"); + * static final ImageIcon longIcon = new ImageIcon("long.gif"); + * static final ImageIcon shortIcon = new ImageIcon("short.gif"); - * All attributes should be static private with accessors to simpify change + * All attributes should be private static with accessors to simpify change - * This class holds only final static member variables that are constants + * This class holds only static final member variables that are constants
16-09-2015