JDK-8132906 : ReadOnly*Wrapper.ReadOnlyPropertyImpl could use ReadOnly*PropertyBase
  • Type: Enhancement
  • Component: javafx
  • Sub-Component: base
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2015-08-03
  • Updated: 2015-10-21
  • Resolved: 2015-08-04
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 8 JDK 9
8u72Fixed 9Fixed
Related Reports
Blocks :  
JDK-8089557 - bindBidirection works for ReadOnly*Wrapper incorrectly
Relates :  
JDK-8089557 - bindBidirection works for ReadOnly*Wrapper incorrectly
Description
Helper classes ReadOnlyPropertyImpl extends ReadOnly*Property and implements all listeners methods themselves.
There are convenient base classes ReadOnly*PropertyBase extends ReadOnly*Property with this implementation.
Comments
Covered by the unit tests from JDK-8089557 : com/sun/javafx/binding/BidirectionalBindingTest javafx/beans/property/ReadOnlyBooleanWrapperTest javafx/beans/property/ReadOnlyDoubleWrapperTest javafx/beans/property/ReadOnlyFloatWrapperTest javafx/beans/property/ReadOnlyIntegerWrapperTest javafx/beans/property/ReadOnlyListWrapperTest javafx/beans/property/ReadOnlyLongWrapperTest javafx/beans/property/ReadOnlyMapWrapperTest javafx/beans/property/ReadOnlyObjectWrapperTest javafx/beans/property/ReadOnlySetWrapperTest javafx/beans/property/ReadOnlyStringWrapperTest
21-10-2015
Great, thanks.
08-10-2015
I don't think so. There seems to be more than enough coverage in existing tests for JDK-8089557. And this fix is about the safest fix I can imagine, since the code in the base class is literally identical to the removed code.
08-10-2015
Is there additional testing that could be done for this and JDK-8089557 ?
08-10-2015
I see. Approved to backport to 8u-dev.
08-10-2015
Kevin, the fix for the JDK-8089557 applies cleanly after this fix otherwise manual merging is needed.
08-10-2015
@Vadim: what is the rationale for backporting this enhancement request? Since it doesn't fix a bug, I am hesitant to take it.
08-10-2015
Changeset: f06e176e6142 Author: vadim Date: 2015-08-04 12:49 +0300 URL: http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/f06e176e6142
04-08-2015