JDK-8128086 : fx2.1-15 (b01): up to 90% regression in Controls.TextArea-select_all-255x1000 in j2d pipeline
  • Type: Bug
  • Component: javafx
  • Sub-Component: controls
  • Affected Version: fx2.1
  • Priority: P5
  • Status: Resolved
  • Resolution: Won't Fix
  • Submitted: 2011-11-17
  • Updated: 2015-06-17
  • Resolved: 2012-07-26
Related Reports
Relates :  
JDK-8091679 - Need a device clip available to the PG node to minimise wasted work
Relates :  
JDK-8118147 - -fx-highlight-text-fill does not work for TextField / PasswordField
Relates :  
JDK-8128574 - TextArea does not set selection fill color
Relates :  
JDK-8101047 - TextArea: performance issue
Description
There is significant Controls.TextArea-select_all-255x1000 in j2d pipeline on all platforms:

winxp-mid: 62% (14.7 -> 5.7 fps)
win7-high: 90% (25.8 -> 2.7 fps)
mac-mid:  27% (28.5 -> 20.7 fps)

The regression first appeared in fx2.1-controls-scrum-b31 which contains the following changes:

1. Fixed RT-17606: TextArea does not set selection fill color
   Fixed RT-17630: TextArea control is unaffected by -fx-text-fill style property (detail)
2. Resolve RT-16722. (detail)
3. fix RT-17699 context menu with sub menus does not disappear when selecting
an item that is in a sub menu. (detail)

Looks like some of them lead to regression.
Note, the regression is only seen in j2d pipeline.


Steps to run benchmark:
> cd tests/performance/Controls/
> ant
> java -cp "${JFX_HOME}/rt/lib/jfxrt.jar;./dist/Controls.jar;../FXBenchmark/dist/FXBenchmark.jar;../../../import/benchmarks-2.1.1/benchmarks-2.1.1.jar"
   -Dprism.order=j2d 
   jrockit.bm.Main controls.bm.TextAreaBenchmark -i 1 -wt 0 -tr 20 -line-len 255 -line-num 1000 -mode SELECT_ALL
Comments
Not important enough to fix.
26-07-2012
We may just close this out as will not fix, because there's nothing we can fix. However for now I'll just downgrade it and defer it out of 2.1
05-01-2012
The fixes that caused this were necessary for correctness and we may just have to live with this although it has been mentioned to me that there are issues in the text control skin that make this more apparent and fixing that could help a lot. I'm not sure why the drop on the win7 high end is quite so much compared to win xp mid. Perhaps it would be instructive to run the tests at full speed with no vsync Fixing RT-16583 and RT-14481 seem unlikely to help as these are issues specific to the prism pipeline and this performance regression is specific to the j2d pipeline.
05-01-2012
This regression happened as a result of fixing RT-16386 and RT-17606, which together implemented foreground color for selected text. It seems related to the performance issue addressed by RT-16853.
17-11-2011