JDK-8102789 : Define API for DatePicker
  • Type: Sub-task
  • Component: javafx
  • Sub-Component: controls
  • Affected Version: 8
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2013-01-02
  • Updated: 2015-06-16
  • Resolved: 2013-05-13
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 8
8Fixed
Description
See attachment.
Comments
Added final. Thanks!
29-04-2013
Only thing I saw is public ObjectProperty<Chronology> chronologyProperty(); public ObjectProperty<StringConverter<LocalDate>> converterProperty(); should both be final
29-04-2013
Is there anything holding back approval for this API?
29-04-2013
Make that 56 cells, including the day names and week numbers.
09-04-2013
I can't judge the impact of using Cell instances on embedded. There will typically be 42 day cells in the calendar. These are reused when switching months. Is there an alternative to using cells? I would think it's good to be consistent with TableView and other controls.
09-04-2013
editor property in ComboBoxBase - probably unlikely. We put it in ComboBox because we didn't want to require all ComboBoxBase implementations to support the concept of an editor. I think this still makes sense...
09-04-2013
Attached the current Modena CSS file for DatePicker. This is likely to change as the implementation proceeds.
09-04-2013
From an API perspective I like the cells, just wondering about practicality on embedded.
09-04-2013
I think it would be good to list the CSS doc here as well so I can take a look at it (but not necessarily in the JavaDoc). The only concern I had about the cell factory, incidentally, is that it means a big heapin' helpin' of nodes for the popup, which I'm concerned with about performance on embedded. I'm wondering if we've done any analysis in terms of footprint / construction time / etc?
09-04-2013
The popup can be customized via CSS. Should I list the style classes here? We may want to add further cell factories for the week number and day name cells in the future, but I don't think they're essential at this point. About the TextEditor property, I will file a tweak request to have it moved to the ComboBoxBase class -- so it's shared with ComboBox.
09-04-2013
To answer Rich's second question, yes: we return editor in ComboBox as well.
09-04-2013
Overall looks great. A couple questions: - How does a developer customize the popup? I see there is a cell for dates, but what about other things like the month, background, buttons, etc? - Are we returning the editor as a TextField in other controls (I think so but can't remember off the top of my head).
09-04-2013