JDK-8101494 : Reduce node count in skin hierarchy for Labeled controls.
  • Type: Enhancement
  • Component: javafx
  • Sub-Component: controls
  • Affected Version: fx2.0
  • Priority: P3
  • Status: Closed
  • Resolution: Fixed
  • Submitted: 2011-07-14
  • Updated: 2015-06-16
  • Resolved: 2011-07-22
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
fx2.0Fixed
Related Reports
Blocks :  
JDK-8101389 - Make Default Cell skins extend Labeled Skin so that we can reduce node count
Relates :  
JDK-8117641 - [CheckBox, RadioButton] Layout regression (was: Text Overrun incorrect work in CheckBox and RadioButton)
Description
A typical Labeled control, such as a text button, adds a hierarchy of five nodes to the scene graph. These are:

- Button (extends Labeled)
-- ButtonSkin (extends SkinBase)
--- Label (extends Labeled)
---- LabelSkin (extends BaseSkin)
----- Text

This can be reduced by two nodes by making the various skins for Labeled controls extend a LabeledSkinBase class, which directly manages the text and graphic nodes. The new hierarchy for the text button now becomes:

- Button (extends Labeled)
-- ButtonSkin (extends LabeledSkin)
--- Text

A new property "labelPadding" is needed on Labeled to manage the padding around the "label" part of composite Labeled controls, such as CheckBox, RadioButton, MenuButton, and SplitMenuButton. This property can be limited to be settable only from CSS with a key "-fx-label-padding", and can be made private in Labeled.
Comments
Verified on build 41. Closed.
25-08-2011
Changeset: http://jfxsrc.us.oracle.com/javafx/presidio/scrum/controls/runtime/rev/6f8bb3429331
22-07-2011
OK / Arch
21-07-2011
OK / SQE
18-07-2011
OK / RM
18-07-2011
OK / Dev (For Nandini Ramani)
18-07-2011
SQE / Approved
18-07-2011
Implementation is finished. The only impact on SQE would be to modify any tests that use CSS to set the padding of the inner .label part of Labeled controls.
15-07-2011