JDK-8098266 : Restore missing comments that were lost in lambda conversion
  • Type: Enhancement
  • Component: javafx
  • Sub-Component: other
  • Affected Version: 8u20
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2014-04-08
  • Updated: 2015-06-12
  • Resolved: 2014-09-04
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 8
8u40Fixed
Related Reports
Relates :  
JDK-8097996 - Use Lambda in FX runtime and samples
Description
The automated tool (IntelliJ) that we used to convert anonymous inner classes to lambda expressions for RT-35197 lost our comments in some cases!
Comments
http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/3f25a032f503
04-09-2014
I took the 12 changesets for RT-35197, generated the diffs, and grep'ed for missing comments. There are only 28 files with missing comments, so restoring them by hand seems easy enough. I have attached the list.
03-09-2014
Here is a particularly bad example of what IntelliJ did to one of our comments: @@ -650,12 +646,7 @@ } final CountDownLatch startupLatch = new CountDownLatch(1); - PlatformImpl.startup(new Runnable() { - // Note, this method is called on the FX Application Thread - @Override public void run() { - startupLatch.countDown(); - } - }); + PlatformImpl.startup(() -> startupLatch.countDown()); // Wait for FX platform to start startupLatch.await(); The important comment "// Note, this method is called on the FX Application Thread" is lost.
08-04-2014