JDK-8097811 : Move Mac specific implementation (support CALayer) out of platform independent code path
  • Type: Enhancement
  • Component: javafx
  • Sub-Component: graphics
  • Affected Version: 8
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2015-01-09
  • Updated: 2015-06-12
  • Resolved: 2015-01-10
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 8
8u60Fixed
Related Reports
Relates :  
JDK-8098031 - Eliminate the need to pass Glass the rendering context to get multi-stage rendering to work on Mac
Description
We can safely (and should) move the following platform specific code out of ES2Context and GLFactory:

        // JIRA: RT-21739
        // TODO: This is a temporary mechanism to work well with Glass on Mac due
        // to the CALayer work. Need to be removed in the early future for 3.0
        if (PlatformUtil.isMac() || PlatformUtil.isIOS()) {
           HashMap devDetails = (HashMap) ES2Pipeline.getInstance().getDeviceDetails();
           ES2Pipeline.glFactory.updateDeviceDetails(devDetails, glContext);
Comments
Changeset: f3578b97ff7b Author: Chien Yang <chien.yang@oracle.com> Date: 2015-01-09 16:56 -0800 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/f3578b97ff7b
10-01-2015
Either is fine with me, too. +1
10-01-2015
@Morris: I prefer not to break the pattern we have with existing updateDeviceDetails(HashMap deviceDetails). But I can see this doesn't matter since it is local and a temporarily with comment. Either way works for me.
10-01-2015
Instead of: + HashMap devDetails = (HashMap) ES2Pipeline.getInstance().getDeviceDetails(); + updateDeviceDetails(devDetails, prismCtx); how about: + HashMap devDetails = (HashMap) ES2Pipeline.getInstance().getDeviceDetails(); + devDetails.put("contextPtr", prismCtx.getNativeHandle()); and do away with updateDeviceDetails().
10-01-2015
Kevin, Please review: http://cr.openjdk.java.net/~ckyang/RT-39783/webrev.00/
09-01-2015
A partial clean up to RT-21739
09-01-2015