JDK-8097782 : ProgressBarSkin should extend ProgressIndicatorSkin.
Type:Enhancement
Component:javafx
Sub-Component:controls
Affected Version:8
Priority:P4
Status:Resolved
Resolution:Fixed
Submitted:2013-08-30
Updated:2015-06-12
Resolved:2014-05-20
The Version table provides details related to the release that this issue/RFE will be addressed.
Unresolved : Release in which this issue/RFE will be addressed. Resolved: Release in which this issue/RFE has been resolved. Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.
Since ProgressBar extends ProgressIndicator, it seems like a better idea to either have ProgressBarSkin extend ProgressIndicatorSkin, or at the least have a ProgressSkinBase from which both extend where the common code can live.
Comments
Changeset: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/e17ba3e406c2
There is more that we can do here, but this is a pretty good start I think.
20-05-2014
I've done as much as I think is possible without decomposing things further. I've tested as much as possible, so I will push to the repo today and wait for the regressions to roll in!
20-05-2014
Will take a look at this soon, and will see if it is possible without regressions.
20-05-2014
This should have a higher priority and should be done for 8u40, if not 8u20. Changes have gone into ProgressIndicatorSkin that haven't been implemented in ProgressBarSkin, and vice-versa. The longer we wait on this, the more divergent the code is going to be. Other than layout, the implementation of things like the indeterminate timeline and various property change listeners should all be the same.