JDK-8097131 : Move com.sun.webkit.dom.JSObject to web module to avoid split package
  • Type: Bug
  • Component: javafx
  • Sub-Component: other
  • Affected Version: 8
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2015-02-07
  • Updated: 2015-06-12
  • Resolved: 2015-02-10
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 8
8u60Fixed
Related Reports
Blocks :  
JDK-8092093 - Modularization support for JavaFX
Relates :  
JDK-8093068 - Eliminate split packages across JavaFX modules
Relates :  
JDK-8097261 - Webkit build failure caused by RT-40000
Description
This is a follow-on bug to redo the fix for part 3 of RT-40000 which had to be reverted. See RT-40006 for details.
Comments
Ok, thanks.
10-02-2015
http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/d1db581f036a
10-02-2015
I can see the concern that stubs might be confusing. I will rename to java-wrappers then.
10-02-2015
This looks fine to me. I have a concern though about the term "stubs". Technically speaking, these files are "wrappers", not "stubs". Or do you think that the name "java-stubs" is ok in its context?
10-02-2015
Please review the following: http://cr.openjdk.java.net/~kcr/RT-40007/webrev.01/ As described in the evaluation of RT-40006, the solution is as follows: 1) Moved the existing "stubs" from modules/web/src/main/java/com/sun/webkit/dom/ to modules/web/src/main/java-stubs/com/sun/webkit/dom/ 2) Changed the build logic to include the stubs directory when not building webkit (as opposed to the former, fragile logic that excluded the entire com.sun.webkit.dom package when building webkit) 3) Moved modules/graphics/src/main/java/com/sun/webkit/dom/JSObject.java to modules/web/src/main/java/com/sun/webkit/dom/ I have tested this both with and without "-PCOMPILE_WEBKIT=true" and it works as expected.
10-02-2015