JDK-8069128 : Fix deprecation warnings in jdk.deploy.osx module
Type:Sub-task
Component:security-libs
Sub-Component:java.security
Priority:P4
Status:Resolved
Resolution:Fixed
Submitted:2015-01-16
Updated:2016-12-14
Resolved:2016-12-09
The Version table provides details related to the release that this issue/RFE will be addressed.
Unresolved : Release in which this issue/RFE will be addressed. Resolved: Release in which this issue/RFE has been resolved. Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.
The deprecation warnings in the jdk.deploy.osx module should be fixed.
Comments
Thanks, Joe -- I see the distinction now.
Anyway, I looked into this a little bit more, and it turns out the fix for this should be to simply remove the @SuppressWarnings("deprecation") annotations, since the deprecated ObjectIdentifier.equals(ObjectIdentifier) method has since been removed (see JDK-8022444) so the code will end up calling the non-deprecated equals(Object) method without any changes.
Also, KeychainStore has been moved to java.base/macosx/classes/apple/security/KeychainStore.java
07-12-2016
The bugs JDK-8069127 and JDK-8069128 are not duplicates. The former just suppresses the deprecation warnings of the code in question. The latter is to, say, recode the methods to not used deprecated elements.
It may be fine to close JDK-8069128 as "will not fix," but it should not be closed as a duplicate of JDK-8069127.
06-12-2016
This one is a dup of JDK-8069127 and is fixed already.
06-12-2016
The observed warnings are:
jdk/src/jdk.deploy.osx/macosx/classes/apple/security/KeychainStore.java:932: warning: [deprecation] equals(ObjectIdentifier) in ObjectIdentifier has been deprecated
if (contentType.equals(ContentInfo.DATA_OID)) {
^
jdk/src/jdk.deploy.osx/macosx/classes/apple/security/KeychainStore.java:956: warning: [deprecation] equals(ObjectIdentifier) in ObjectIdentifier has been deprecated
if (contentType.equals(ContentInfo.DATA_OID)) {
^
jdk/src/jdk.deploy.osx/macosx/classes/apple/security/KeychainStore.java:958: warning: [deprecation] equals(ObjectIdentifier) in ObjectIdentifier has been deprecated
} else if (contentType.equals(ContentInfo.ENCRYPTED_DATA_OID)) {
^
jdk/src/jdk.deploy.osx/macosx/classes/apple/security/KeychainStore.java:998: warning: [deprecation] equals(ObjectIdentifier) in ObjectIdentifier has been deprecated
if (bagId.equals(PKCS8ShroudedKeyBag_OID)) {
^
error: warnings found and -Werror specified
1 error
4 warnings