JDK-8065137 : Remove unecessary generalizations in cardTableModRefBS.cpp
  • Type: Enhancement
  • Component: hotspot
  • Sub-Component: gc
  • Affected Version: 9
  • Priority: P4
  • Status: Closed
  • Resolution: Other
  • Submitted: 2014-11-17
  • Updated: 2020-09-24
  • Resolved: 2020-09-24
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
tbdResolved
Related Reports
Relates :  
JDK-8064721 - The card tables only ever need two covering regions
Relates :  
JDK-8059066 - CardTableModRefBS might commit the same page twice
Description
The code in CardTableModRefsBS is unfortunately very generic, it does not utilize the fact that we only have two generations, two committed regions and only one shared page. This makes the code unnecessarily hard to follow.

Similarly to how the Generations abstraction was cleaned up in genCollectedHeap.cpp, these no longer needed abstractions should be removed.
Comments
I don't think this is a problem anymore. The classes have been rewritten and the names have changed. There's *a lot* of changes around the GenCollectedHeap that can be cleaned up now that CMS is gone. Let's open new, relevant RFEs.
24-09-2020
See the discussion in the review requests for JDK-8059066 and JDK-8064721 for more details: - http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2014-October/011067.html - http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2014-November/011279.html
17-11-2014