JDK-8036584 : Review comments from 8035897
  • Type: Bug
  • Component: core-libs
  • Sub-Component: java.net
  • Priority: P4
  • Status: Closed
  • Resolution: Fixed
  • Submitted: 2014-03-04
  • Updated: 2016-06-13
  • Resolved: 2014-03-04
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 7 JDK 8 JDK 9
7u60Fixed 8u11Fixed 9 b04Fixed
Related Reports
Relates :  
JDK-8035897 - Better memory allocation for file descriptors greater than 1024 on macosx
Description
Review comments form 8035897, received after the changes were pushed. See
  http://mail.openjdk.java.net/pipermail/net-dev/2014-March/008303.html

--- snip --

This mostly looks okay to me although it's a bit inconsistent for 
NET_Timeout to have a JNIEnv parameter. It might be better to have it 
set errno to ENOMEM or some error and handle it in the call instead. 
Also just on the exception message, I assume it should be "select" 
rather than NET_Select as NET_Select has been removed.

--- snip ---