JDK-8021237 : clean up JavacAnnotatedConstruct
  • Type: Bug
  • Component: tools
  • Sub-Component: javac
  • Affected Version: 8
  • Priority: P3
  • Status: Closed
  • Resolution: Fixed
  • Submitted: 2013-07-24
  • Updated: 2024-01-12
  • Resolved: 2013-10-10
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 8
8 b113Fixed
Related Reports
Relates :  
JDK-7193719 - Support repeating annotations in javax.lang.model
Relates :  
JDK-8323684 - TypeMirror.{getAnnotationsByType, getAnnotation} return uninformative results
Description
model/JavacAnnotatedConstruct needs to be cleaned up.

- We need input validation on unpacking the the array for repeated annotations.

- There is lots of code duplication

- The functionality should be moved to preferably an abstract base type to Symbol and Type. If that introduced  performance penalty in general the file can be refactored, most of the methods can be moved to Symbol or Type and a common interface JCAnnoConstruct can be introduced. In 9 we can then move the rest of this code into default methods in JCAnnoConstruct.
Comments
URL: http://hg.openjdk.java.net/jdk8/jdk8/langtools/rev/1e7ad879f15e User: lana Date: 2013-10-22 16:31:57 +0000
22-10-2013
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1e7ad879f15e User: jfranck Date: 2013-10-10 08:57:13 +0000
10-10-2013