JDK-6953952 : collectedHeap.cpp should use #ifdef _LP64 not LP64
  • Type: Enhancement
  • Component: hotspot
  • Sub-Component: gc
  • Affected Version: hs19
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • OS: generic
  • CPU: generic
  • Submitted: 2010-05-19
  • Updated: 2013-09-18
  • Resolved: 2010-06-01
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 6 JDK 7 Other
6u21pFixed 7Fixed hs19Fixed
Related Reports
Relates :  
JDK-6578152 - fill_region_with_object has usability and safety issues
Description
From email thread on openjdk:-

Vladimir Kozlov wrote:
> The file also have LP64 instead of _LP64:
>
> src/share/vm/gc_interface/collectedHeap.cpp:#ifdef LP64
>

Yes, that one is probably not fatal (as far as i can see because
i think LP64 gets defined when building 64-bit and this has been around
a lot longer than COMPLER2; i'll check), but we should fix that too...

thanks Vladimir.
-- ramki


> Vladimir
>
> Y. Srinivas Ramakrishna wrote:
>> 6953483 Typo related to ReduceInitialCardMarks
>>
>> Workaround for the case of CMS: -XX:-ReduceInitialCardMarks.
>>
>> No issue for other collectors (G1, which may otherwise have been
>> vulnerable, has this optimization switched off).
>>
>> Thanks, ChenGuang, for bringing this to our attention.
>> -- ramki
>>
>> Y. Srinivas Ramakrishna wrote:
>>> Looks like I am responsible for that typo (which is still there).
>>> I'll test and fix that issue. Thanks for the fix!
>>>
>>> -- ramki
>>>
>>> ChenGuang Sun wrote:
>>>> Hi,
>>>>
>>>>     I'm reading the code and have noticed a minor typo in the function
>>>> "CollectedHeap::pre_initialize()".
>>>>
>>>>     I think it should be "#ifdef COMPILER2" instead of "#ifdef
>>>> COMPLER2". I haven't checked whether it has been corrected in the
>>>> latest revision.
>>>>
>>>> Thanks,
>>>> Chen
Comments
EVALUATION http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/1634cec09505
20-05-2010
SUGGESTED FIX diff -r 15190cbcabe9 src/share/vm/gc_interface/collectedHeap.cpp --- a/src/share/vm/gc_interface/collectedHeap.cpp Wed May 19 10:37:05 2010 -0700 +++ b/src/share/vm/gc_interface/collectedHeap.cpp Wed May 19 11:34:30 2010 -0700 @@ -309,7 +309,7 @@ void CollectedHeap::fill_with_objects(He DEBUG_ONLY(fill_args_check(start, words);) HandleMark hm; // Free handles before leaving. -#ifdef LP64 +#ifdef _LP64 // A single array can fill ~8G, so multiple objects are needed only in 64-bit. // First fill with arrays, ensuring that any remaining space is big enough to // fill. The remainder is filled with a single object.
19-05-2010
EVALUATION As in synopsis.
19-05-2010
WORK AROUND None needed. This was just a matter of code hygiene, that's all.
19-05-2010