JDK-6566375 : PIT : test/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html
  • Type: Bug
  • Component: client-libs
  • Sub-Component: java.awt
  • Affected Version: 7
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • OS: generic,solaris_10
  • CPU: generic,sparc
  • Submitted: 2007-06-06
  • Updated: 2011-01-24
  • Resolved: 2009-12-16
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 7 Other
7 b78Fixed OpenJDK6Fixed
Related Reports
Duplicate :  
JDK-6847131 - test/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html fails
Duplicate :  
JDK-6618531 - test java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html fails with latest JDK 7
Relates :  
JDK-7063231 - TEST: java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html backport to jdk6
Relates :  
JDK-6276704 - Regression: CTE_REGTEST/Generic/4799136/Bug4799136.java fails
Description
test/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html passes in jdk7 b13 but fails in pit builds 
java version "1.7.0-internal"
Java(TM) SE Runtime Environment (build 1.7.0-internal-jcg-integrator_29_May_2007_17_59-b00)
Java HotSpot(TM) Tiered VM (build 1.7.0-ea-b13, mixed mode)

I have attached the log file.
Comments
SUGGESTED FIX test/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.java Print this page @@ -48,17 +48,11 @@ * summary: */ import java.applet.Applet; import java.awt.*; -import java.lang.reflect.InvocationTargetException; import java.awt.event.*; -import java.awt.peer.DialogPeer; -import java.awt.peer.ComponentPeer; -import java.lang.reflect.Method; -import java.lang.reflect.Proxy; -import java.lang.reflect.InvocationHandler; import java.lang.reflect.InvocationTargetException; import test.java.awt.regtesthelpers.Util; //Automated tests should run as applet tests if possible because they // get their environments cleaned up, including AWT threads, any @@ -92,15 +86,17 @@ public void eventDispatched(AWTEvent e) { System.err.println(e.toString()); } }, AWTEvent.KEY_EVENT_MASK); + KeyboardFocusManager.setCurrentKeyboardFocusManager(new TestKFM()); + this.setLayout (new BorderLayout ()); f = new Frame("frame"); b = new Button("press"); - d = new TestDialog(f, "dialog", true, robotSema); + d = new Dialog(f, "dialog", true); ok = new Button("ok"); d.add(ok); d.pack(); ok.addKeyListener(new KeyAdapter() { @@ -168,10 +164,15 @@ try { robotSema.doWait(1000); } catch (InterruptedException ie) { throw new RuntimeException("Interrupted!"); } + if (!robotSema.getState()) { + throw new RuntimeException("robotSema hasn't been triggered"); + } + + System.err.println("typing ahead"); robot.keyPress(KeyEvent.VK_SPACE); robot.keyRelease(KeyEvent.VK_SPACE); waitForIdle(); try { pressSema.doWait(3000); @@ -276,69 +277,18 @@ public synchronized boolean getState() { return state; } } - // Fix for 6446952. - // In the process of showing the dialog we have to catch peer.show() call - // so that to trigger key events just before it gets invoked. - // We base on the fact that a modal dialog sets type-ahead markers - // before it calls 'show' on the peer. - // Posting the key events before dialog.setVisible(true) would be actually not - // good because it would be Ok to dispatch them to the current focus owner, - // not to the dialog. - class TestDialog extends Dialog { - ComponentPeer origDialogPeer; - ComponentPeer proxyInstPeer; - Semaphore trigger; - - TestDialog(Frame owner, String title, boolean modal, Semaphore trigger) { - super(owner, title, modal); - this.trigger = trigger; - } - public ComponentPeer getPeer() { - ComponentPeer ret = super.getPeer(); - if (ret == proxyInstPeer) { - return origDialogPeer; - } else { - return ret; - } - } - - public void addNotify() { - super.addNotify(); - replacePeer(); - } - - void replacePeer() { - origDialogPeer = getPeer(); - - InvocationHandler handler = new InvocationHandler() { - public Object invoke(Object proxy, Method method, Object[] args) { - if (method.getName() == "show") { - trigger.raise(); - } - - Object ret = null; - try { - ret = method.invoke(origDialogPeer, args); - } catch (IllegalAccessException iae) { - throw new Error("Test error.", iae); - } catch (InvocationTargetException ita) { - throw new Error("Test error.", ita); - } - return ret; - } - }; - - proxyInstPeer = (DialogPeer)Proxy.newProxyInstance( - DialogPeer.class.getClassLoader(), new Class[] {DialogPeer.class}, handler); + class TestKFM extends DefaultKeyboardFocusManager { + protected synchronized void enqueueKeyEvents(long after, + Component untilFocused) + { + super.enqueueKeyEvents(after, untilFocused); - try { - Util.getField(Component.class, "peer").set(d, proxyInstPeer); - } catch (IllegalAccessException iae) { - throw new Error("Test error.", iae); + if (untilFocused == TestDialogTypeAhead.this.ok) { + TestDialogTypeAhead.this.robotSema.raise(); } } } }// class TestDialogTypeAhead
02-12-2009
EVALUATION it is a bug in the test. It tries to provide its own implementation of DialogPeer interface (using Proxy). And so it doesn't work with the code which tries to cust peer to some specific class (such as XDialogPeer). Need to think how to change the test to avoid this problem.
06-06-2007