JDK-6356966 : LDAP Group support needs resource cleanup
  • Type: Bug
  • Component: core-libs
  • Sub-Component: javax.naming
  • Affected Version: 1.1
  • Priority: P4
  • Status: Closed
  • Resolution: Duplicate
  • OS: generic
  • CPU: generic
  • Submitted: 2005-11-30
  • Updated: 2010-08-19
  • Resolved: 2005-12-02
Related Reports
Duplicate :  
JDK-6351539 - LDAP implementation of JNDI when used with connection pooling enabled hangs
Relates :  
JDK-5075338 - Document removal of references to the object in getObjectInstance() method
Description
The LdapGroupFactory when it creates the Group objects in the getObjectInstance() method should
release the DirContext object if used by it.
Otherwise it will hold a reference to a Context object that will create problems when connection pooling is used for it will hold the resources for ever. This will result in application running out of resources soon the pool becomes full.

This bug is the root cause of the Sun Java Application Server bug: 6351539
I think I shouldn't have filed this bug, as we don't have a category in the bugster for the LDAP Booster Pack bugs.

I will close this as a duplicate of 6351539 rather than the other way around.
I'm closing this right now because this bug is showing up in the EC bug list for
mustang and we should get this bug off the list by closing it.
Comments
SUGGESTED FIX A fix along the lines of following code would fix the problem: --- LdapGroupFactory.java Tue Nov 29 19:07:32 2005 *** 111,139 **** */ public Object getObjectInstance(Object obj, Name name, Context ctx, Hashtable environment, Attributes attributes) throws Exception { if (obj instanceof DirContext && ctx instanceof DirContext) { // examine the objectClass attribute Attribute objectClass = (attributes != null ? attributes.get("objectClass") : null); if (objectClass != null) { // interested only in group objects if (GroupOfURLs.matches(objectClass)) { return GroupOfURLs.getObjectInstance( ! ((DirContext)obj).getNameInNamespace(), (DirContext)ctx, ! name, environment, attributes); } else if (GroupOfUniqueNames.matches(objectClass)) { return GroupOfUniqueNames.getObjectInstance( ! ((DirContext)obj).getNameInNamespace(), (DirContext)ctx, ! name, environment, attributes); } else if (GroupOfNames.matches(objectClass)) { return GroupOfNames.getObjectInstance( ! ((DirContext)obj).getNameInNamespace(), (DirContext)ctx, ! name, environment, attributes); } } } return null; } --- 111,145 ---- */ public Object getObjectInstance(Object obj, Name name, Context ctx, Hashtable environment, Attributes attributes) throws Exception { if (obj instanceof DirContext && ctx instanceof DirContext) { + // examine the objectClass attribute Attribute objectClass = (attributes != null ? attributes.get("objectClass") : null); if (objectClass != null) { + DirContext dirCtxObj = (DirContext) obj; + String dn = dirCtxObj.getNameInNamespace(); + // interested only in group objects if (GroupOfURLs.matches(objectClass)) { + + // release the resources held by obj ctx + dirCtxObj.close(); return GroupOfURLs.getObjectInstance( ! dn, (DirContext)ctx, name, environment, attributes); } else if (GroupOfUniqueNames.matches(objectClass)) { + dirCtxObj.close(); return GroupOfUniqueNames.getObjectInstance( ! dn, (DirContext)ctx, name, environment, attributes); } else if (GroupOfNames.matches(objectClass)) { + dirCtxObj.close(); return GroupOfNames.getObjectInstance( ! dn, (DirContext)ctx, name, environment, attributes); } } } return null; }
30-11-2005