JDK-5035138 : Wrong extra line in FilePane.java due to putback error
  • Type: Bug
  • Component: client-libs
  • Sub-Component: javax.swing
  • Affected Version: 5.0
  • Priority: P2
  • Status: Resolved
  • Resolution: Fixed
  • OS: windows_nt
  • CPU: x86
  • Submitted: 2004-04-21
  • Updated: 2004-05-03
  • Resolved: 2004-05-03
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Other
5.0 b50Fixed
Related Reports
Relates :  
JDK-4997165 - REGRESSION:JFileChooser throws NPE
Description

Name: keR10081			Date: 04/21/2004


Due to some putback error in the fix for bug 4997165, we left one line
of code unchanged while having its correct variant added. Namely, fix
should replace
! 		listSelectionModel.clearSelection();
with
! 		if (isShowing()) listSelectionModel.clearSelection();
but currently we have
		if (isShowing()) {
                     listSelectionModel.clearSelection();
                 }
		listSelectionModel.clearSelection();
this may lead to failure of tests mentioned in 4997165 on some platforms.
======================================================================
Comments
CONVERTED DATA BugTraq+ Release Management Values COMMIT TO FIX: tiger-beta2 FIXED IN: tiger-beta2 INTEGRATED IN: tiger-b50 tiger-beta2
24-08-2004
EVALUATION Name: keR10081 Date: 04/21/2004 We need to remove that extra line. See suggested fix for details. ###@###.### ======================================================================
24-08-2004
SUGGESTED FIX Name: keR10081 Date: 04/21/2004 *** /net/diablo/export2/swing/kve/dragon/webrev/src/share/classes/sun/swing/FilePane.java- Wed Apr 21 17:32:04 2004 --- FilePane.java Wed Apr 21 17:30:08 2004 *************** *** 439,445 **** if (isShowing()) { listSelectionModel.clearSelection(); } - listSelectionModel.clearSelection(); updateListRowCount(list); } }); --- 439,444 ---- ======================================================================
24-08-2004