JDK-4310378 : javax.swing.DefaultPopupFactory.* inner classes should be package-private
  • Type: Bug
  • Component: client-libs
  • Sub-Component: javax.swing
  • Affected Version: 1.3.0
  • Priority: P4
  • Status: Closed
  • Resolution: Duplicate
  • OS: generic
  • CPU: generic
  • Submitted: 2000-02-07
  • Updated: 2000-11-04
  • Resolved: 2000-11-04
Related Reports
Duplicate :  
Description

Name: krT82822			Date: 02/06/2000


java 1.3rc1

javax.swing.DefaultPopupFactory is a package-private class
It has three protected inner classes.

Since the containing class is package private, it cannot be subclassed
by anything outside of the package.  Therefore, making the inner classes
protected doesn't buy you anything.

Since there is no reason to make them protected, it would be better (IMHO) to
leave them package private.
(Review ID: 100793) 
======================================================================

Comments
EVALUATION I am marking this as a dup of 4303635. As a result of this bug, these classes have been rewritten and no longer exist (although much of the code is now in PopupFactory, but doesn't have the same problems). scott.violet@eng 2000-11-03
03-11-2000