JDK-8250928 : JFR: Improve hash algorithm for stack traces
  • Type: Enhancement
  • Component: hotspot
  • Sub-Component: jfr
  • Affected Version: 8,13,14,15,16
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2020-08-02
  • Updated: 2024-11-18
  • Resolved: 2020-08-07
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 11 JDK 13 JDK 15 JDK 16 Other
11.0.10-oracleFixed 13.0.6Fixed 15.0.2Fixed 16 b11Fixed openjdk8u282Fixed
Related Reports
Relates :  
JDK-8252754 - Hash code calculation of JfrStackTrace is inconsistent
Description
There is contention in JfrStackTraceRepository::add_trace. For details, see:

https://mail.openjdk.java.net/pipermail/hotspot-jfr-dev/2020-July/001605.html
Comments
Fix request (13u) Requesting backport to 13u for parity with 11u. Minor adjustments needed to apply the patch. tier1 and jdk/jfr tests pass. RFR approval: http://mail.openjdk.java.net/pipermail/jdk-updates-dev/2020-November/004114.html
11-11-2020
Hi [~clanger] - done!
22-09-2020
[8u] Fix Request I would like to request a backport of this fix improving the hashing function and reducing the chance of conflict in storing JFR stacktrace data. The patch applies almost cleanly with only hunk offset. RFR: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-August/012596.html Tier1 and JFR tests were executed to check for any regressions and all expected tests passed.
01-09-2020
[11u] Fix Request I would like to request a backport of this fix improving the hashing function and reducing the chance of conflict in storing JFR stacktrace data. The patch applies almost cleanly with only hunk offset. RFR: https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2020-September/003730.html Tier1 and JFR tests were executed to check for any regressions and all expected tests passed.
01-09-2020
Hi [~jbachorik], please post for RFR at jdk-updates-dev.
01-09-2020
[15u] Fix Request I would like to request a backport of this fix improving the hashing function and reducing the chance of conflict in storing JFR stacktrace data. The patch applies cleanly with no changes required. Tier1 and JFR tests were executed to check for any regressions and all expected tests passed.
31-08-2020
Hi [~hirt], I'm removing the jdk11u-fix-request label as there is no further information given, e.g. if the patch applies cleanly, risk etc. So, somebody doing the backport to 11u would need to give this information and also do the push after approval.
27-08-2020
Please provide a justification/ risk assessment for getting this into 15u.
11-08-2020
URL: https://hg.openjdk.java.net/jdk/jdk/rev/c3cc9ac0ede2 User: egahlin Date: 2020-08-07 02:20:42 +0000
07-08-2020
Contributor: Gabriel Reid (gabriel.reid@datadoghq.com)
07-08-2020
If the findings generally hold - we should try hard to get the changes into the next release possible.
04-08-2020
See also the following entry for webrev: https://mail.openjdk.java.net/pipermail/hotspot-jfr-dev/2020-July/001612.html
04-08-2020