JDK-8239400 : [8u] clean up delete-non-virtual-dtor warnings in HotSpot
  • Type: Bug
  • Component: hotspot
  • Priority: P2
  • Status: Closed
  • Resolution: Fixed
  • Submitted: 2020-02-19
  • Updated: 2021-05-27
  • Resolved: 2020-02-21
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 8 Other
8u251Fixed openjdk8u302Fixed
Description
There are a number of delete-non-virtual-dtor warnings which cause compilation failure on recent versions of Xcode. We will fix this warning as part of our toolchain upgrade effort.

This is not simply a warnings cleanup. HotSpot crashes when built with Xcode 10.1 without the fix to PerfData destructor.

This is a partial backport of Paul Hohensee's massive cleanup [0] of Xcode warnings. A complete backport of that chnageset is well beyond the scope of our toolchain upgrade work. But we do want to clean up as many warnings as we can with minimal risk.

Unlike Paul's fix, for 8u we only added / modified destructor declarations in the base classes and did *not* add explicit destructors to any of the derived classes. We also left the delete-non-virtual-dtor warnings disabled as it is believed that this warning frequently triggers false positives and has subsequently been re-enabled in mainline.

[0] http://hg.openjdk.java.net/jdk10/jdk10/hotspot/rev/c044f8d03932

Comments
Fix Request (8u). Review threads: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2021-May/013835.html https://mail.openjdk.java.net/pipermail/jdk8u-dev/2021-May/013836.html Review approval: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2021-May/013894.html
26-05-2021