JDK-8235243 : handle VS2017 15.9 and VS2019 in abstract_vm_version
  • Type: Bug
  • Component: hotspot
  • Sub-Component: runtime
  • Affected Version: 11,14
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • OS: generic
  • CPU: generic
  • Submitted: 2019-12-03
  • Updated: 2022-01-05
  • Resolved: 2019-12-04
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 11 JDK 13 JDK 14 JDK 7 JDK 8 Other
11.0.10-oracleFixed 13.0.4Fixed 14 b26Fixed 7u281Fixed 8u270Fixed openjdk8u272Fixed
Related Reports
Relates :  
JDK-8235325 - build failure on Linux after 8235243
Description
The C++ compiler handling coding in abstract_vm_version.cpp currently misses handling nicely VS2017 15.9 and VS2019.
This leads to bad output like „unknown MS VC++:1916“  in the hs_err file.
Comments
Fix Request (8u): Backport to 8u requested because it is a part of 8u271-oracle. 11u patch depends on JDK-8211714 and applies cleanly on top of it after paths re-shuffling, exported 8u-dev commit with original attribution: http://cr.openjdk.java.net/~akasko/jdk8u/8235243/8235243_8u.patch Testing: checked that it builds correctly on Windows (with vs2010 and vs2017) and on Linux, checked that compiler version 1916 is recognized correctly with the patch.
12-06-2020
Fix request (13u): The change is exactly same as for 14, but should be applied to a different file: vm_version.cpp instead of abstract_vm_version.cpp, because fix for 8233787, which introduces the abstract_vm_version.cpp, is not backported to 13u. RFR: https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2020-June/003235.html
05-06-2020
JDK 11 review thread: https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2019-December/002216.html
12-12-2019
jdk11 fix request I would like to have the patch in jdk11 as well, because the issue is present there too. The fix must be done for jdk11 in a separate file (vm_version.cpp , not abstract_vm_version.cpp), see https://bugs.openjdk.java.net/browse/JDK-8235478
12-12-2019
Fixed by JDK-8235325.
04-12-2019
JDK build failed after this patch src/hotspot/share/runtime/abstract_vm_version.cpp:239:40: error: missing terminating " character [-Werror] #define HOTSPOT_BUILD_COMPILER "MS VC++ 16.3 (VS2019) The " character after (VS2019) is missing!
04-12-2019
URL: https://hg.openjdk.java.net/jdk/jdk/rev/775b714a2e49 User: mbaesken Date: 2019-12-04 08:08:21 +0000
04-12-2019