JDK-8222563 : Remove terminally deprecated method netscape.javascript.JSObject::getWindow
  • Type: Enhancement
  • Component: deploy
  • Affected Version: 14
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2019-04-16
  • Updated: 2019-08-06
  • Resolved: 2019-06-25
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 14
14 b08Fixed
Related Reports
CSR :  
Relates :  
Sub Tasks
JDK-8226774 :  
The netscape.javascript.JSObject::getWindow method was deprecated in JDK 9 and deprecated for-removal in JDK 12. The presence of this method causes an otherwise unneeded dependency on the java.desktop module by the jdk.jsobject module.

I propose to remove this method from the jDK as of JDK 14 along with the then-unneeded dependency. 
URL: https://hg.openjdk.java.net/jdk/jdk/rev/d0c2e34bae88 User: psadhukhan Date: 2019-07-25 06:51:25 +0000

UPdated webrev: http://cr.openjdk.java.net/~kcr/8222563/webrev.01/ For completeness, I uploaded a webrev with the copyright changes reverted (I also added the 'Reviewed-by' line in the changeset commit message). The CSR still needs to be approved.

OK, I'll revert it when I send the final patch to be pushed (unless there are other comments, in which case I'll fix it in the next version of the webrev).

I think it most correct to revert it.

A fair point. Unless I'm just touching the copyright header itself, I will err on the side of updating to the current year. I'll revert the copyright year change if you prefer.

The change looks fine to me. I do question the need or appropriateness of + * Copyright (c) 2016, 2019, Oracle and/or its affiliates. All rights reserved. when there is nothing new to copyright. You are only removing content You may as well then add (c) 2019 in the file you are deleting too ...

Review thread: https://mail.openjdk.java.net/pipermail/awt-dev/2019-June/015278.html Webrev: http://cr.openjdk.java.net/~kcr/8222563/webrev.00/ The fix removes the netscape.javascript.JSObject::getWindow(Applet) method along with the (not exported) service provider interface that was used by getWindow; as of JDK 11 there are no implementations of this provider. The fix also removes the dependency on the java.desktop module from the module-info.java file of the jdk.jsobject module.