JDK-8210219 : GlassClipboard.cpp fails to compile with newer versions of VS2017
  • Type: Bug
  • Component: javafx
  • Sub-Component: graphics
  • Affected Version: 8u181,openjfx11,openjfx12
  • Priority: P2
  • Status: Resolved
  • Resolution: Fixed
  • OS: windows
  • Submitted: 2018-08-30
  • Updated: 2020-01-31
  • Resolved: 2018-08-31
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 8 Other
8u202Fixed openjfx11.0.2Fixed
Related Reports
Blocks :  
Description
GlassClipboard.cpp fails to compile when building with a newer version of VS2017, for example VC 14.15.26726:

...\modules\javafx.graphics\src\main\native-glass\win\GlassClipboard.cpp(86): error C2065: '_HASH_SEED': undeclared identifier

This was discovered and reported on GitHub as: https://github.com/javafxports/openjdk-jfx/issues/183 when the AppVeyor builds started failing (they recently updated their version of VS 2017).

I raised the priority to P2, since it causes the AppVeyor build to fail, which we use to test pull requests.
Comments
+1 for the 11u-dev backport
10-01-2019

Same holds for 11u. The patch at http://hg.openjdk.java.net/openjfx/jfx-dev/rt/rev/30c0d3317713 works with 11-dev and I request a backport of this fix to 11-dev
10-01-2019

We need to backport this to 8u, since we will almost certainly upgrade the compilers in 8u in the near future.
31-08-2018

Changeset: 30c0d3317713 Author: kcr Date: 2018-08-31 04:53 -0700 URL: http://hg.openjdk.java.net/openjfx/jfx-dev/rt/rev/30c0d3317713 8210219: GlassClipboard.cpp fails to compile with newer versions of VS2017 Reviewed-by: arajkumar
31-08-2018

Review on GitHub: https://github.com/javafxports/openjdk-jfx/pull/185
31-08-2018