JDK-8210147 : adjust some WSAGetLastError usages in windows network coding
  • Type: Bug
  • Component: core-libs
  • Sub-Component: java.net
  • Affected Version: 12
  • Priority: P3
  • Status: Closed
  • Resolution: Fixed
  • OS: windows
  • CPU: generic
  • Submitted: 2018-08-29
  • Updated: 2020-08-14
  • Resolved: 2018-08-30
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 11 JDK 12 JDK 8 Other
11.0.8Fixed 12 b10Fixed 8u251Fixed openjdk8u272Fixed
Description
There are a number usages of the WSAGetLastError function in the windows network coding that are a bit problematic :
- at one place the function is not called immediately  after error ( jdk/src/java.base/windows/native/libnet/SocketInputStream.c)
- at 2 places the function is used  where no socket error occured but malloc failed (jdk/src/java.base/windows/native/libnet/Inet6AddressImpl.c  ping6  and  jdk/src/java.base/windows/native/libnet/Inet4AddressImpl.c  ping4 )
 
Comments
Fix Request (8u): Backport to 8u requested because it is a part of 8u251-oracle. Patch doesn't apply cleanly to 8u, review thread: https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-June/012025.html
19-06-2020

jdk11 backport request I would like to have the patch in OpenJDK11 as well (for better parity with 11.0.8_oracle). The patch applies cleanly.
20-05-2020