JDK-8193798 : Cherry pick GTK WebKit 2.18.4 changes
  • Type: Bug
  • Component: javafx
  • Sub-Component: web
  • Affected Version: 10
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • OS: generic
  • CPU: generic
  • Submitted: 2017-12-19
  • Updated: 2020-01-31
  • Resolved: 2018-01-05
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 10 JDK 8
10Fixed 8u171Fixed
Related Reports
Cloners :  
GTK WebKit 2.18.4 is about to release, we should merge all stabilization patches from 2.18 branch[1].

[1] https://trac.webkit.org/log/webkit/releases/WebKitGTK/webkit-2.18
changeset: aefda57f2ae9 user: arajkumar date: Fri Jan 05 11:40:42 2018 +0530 description: 8193798: Cherry pick GTK WebKit 2.18.4 changes Reviewed-by: kcr, ghb, mbilla URL: http://hg.openjdk.java.net/openjfx/10-dev/rt/rev/aefda57f2ae9

+1 with below nit: Typo correction (modules/javafx.web/src/main/native/CMakeLists.txt) : "two fist commands" , pls correct fist to first .

+1, Compiled on Linux and compared the drt with and without this fix, didn't see any difference.

I'll test it on Mac and Linux and let you know if there are any problems with the build. One thing I did run into is extra white-space in the following file, which will fail jcheck: modules/javafx.web/src/main/native/Source/WebCore/loader/FrameLoader.h

Code changes look good. Ran unit tests on all three platforms with no problems. +1 pending the fix to remove the trailing whitespace.