JDK-8167100 : Minor source diffs introduced in backports of JDK-8160837 and JDK-8163582
  • Type: Bug
  • Component: javafx
  • Sub-Component: web
  • Affected Version: 8u152
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2016-10-04
  • Updated: 2018-03-02
  • Resolved: 2016-10-07
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
Related Reports
Blocks :  
Relates :  
Relates :  
This was discovered while auditing the diffs in the native WebKit code between FX 9-dev and 8u-dev. Except for JDK-9-specific build changes there should be no differences, but there are.

diff -u -r /localhome/kcr/javafx/8u-kcr/jfx/rt/modules/web/src/main/native/Source/WebCore/page/java/ChromeClientJava.cpp modules/javafx.web/src/main/native/Source/WebCore/page/java/ChromeClientJava.cpp
--- /localhome/kcr/javafx/8u-kcr/jfx/rt/modules/web/src/main/native/Source/WebCore/page/java/ChromeClientJava.cpp	2016-10-04 08:26:58.072703138 -0700
+++ modules/javafx.web/src/main/native/Source/WebCore/page/java/ChromeClientJava.cpp	2016-10-04 09:01:34.296720318 -0700
@@ -5,7 +5,6 @@
 #include "ChromeClientJava.h"
-#include "ColorChooser.h"
 #include "ColorChooserJava.h"
 #include "ContextMenu.h"
diff -u -r /localhome/kcr/javafx/8u-kcr/jfx/rt/modules/web/src/main/native/Source/WebCore/platform/graphics/PathTraversalState.cpp modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/PathTraversalState.cpp
--- /localhome/kcr/javafx/8u-kcr/jfx/rt/modules/web/src/main/native/Source/WebCore/platform/graphics/PathTraversalState.cpp	2016-10-04 08:27:04.488703191 -0700
+++ modules/javafx.web/src/main/native/Source/WebCore/platform/graphics/PathTraversalState.cpp	2016-10-04 09:01:34.296720318 -0700
@@ -280,4 +280,3 @@

changeset: 1545e537eb29 user: arajkumar date: Fri Oct 07 11:39:26 2016 +0530 files: modules/web/src/main/native/Source/WebCore/page/java/ChromeClientJava.cpp modules/web/src/main/native/Source/WebCore/platform/graphics/PathTraversalState.cpp description: 8167100: Minor source diffs introduced in backports of JDK-8160837 and JDK-8163582 Reviewed-by: kcr, ghb URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/1545e537eb29





Applying the patch listed in the description to 8u-dev is probably the easiest way to fix this issue. Alternatively, you could apply the anti-delta of that to 9-dev, but it seems cleaner to keep the two minor changes as they exist in 9.

Bisecting the first issue shows this: The first bad revision is: changeset: 9936:c82cdfad0fc8 user: ghb date: Fri Jul 22 06:33:32 2016 +0530 summary: 8160837 : WebEngine doesn't handle html5 color picker And bisecting the second issues shows this: The first bad revision is: changeset: 9988:1356c2c9355a user: ghb date: Fri Aug 12 22:23:51 2016 +0530 summary: 8163582: JavaFX browser can get stuck in an infinite loop when calling path.getTotalLength() In both cases, the changeset pushed to 9-dev is fine, but the backport to 8u-dev is slightly different (perhaps it was done manually).