JDK-8089264 : DRT test fast/events/before-unload-returnValue.html times out
  • Type: Bug
  • Component: javafx
  • Sub-Component: web
  • Affected Version: 8u25,9
  • Priority: P3
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2014-09-10
  • Updated: 2020-01-31
  • Resolved: 2017-12-11
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 10 JDK 8
10Fixed 8u171Fixed
Related Reports
Relates :  
JDK-8160749 - WebView does not support window.onbeforeunload
Description
DRT test fast/events/before-unload-returnValue.html times out in DRT mode and doesn't work in manual mode.
This is a newly-added test.
Comments
changeset: a6a636ef3912 date: Fri Nov 03 14:33:47 2017 +0530 description: 8089264: DRT test fast/events/before-unload-returnValue.html times out Reviewed-by: ghb, mbilla, rkamath URL: http://hg.openjdk.java.net/openjfx/jfx-dev/rt/rev/a6a636ef3912
11-12-2017
Thanks [~arajkumar] +1
11-12-2017
>> [~arajkumar] Just curious to know, are we missing some more functionality to make below 2 cases to pass ? >> running fast/events/before-unload-navigate-different-window.html -> failed >> running fast/events/before-unload-open-window.html -> failed [~mbilla], Looks like above 2 tests are part of new WebKit upgrade(JDK-8187483) also failed due to my local DRT change which reduces timeout to 3 secs. I retried without my local change and it passes.
11-12-2017
Changes look good to me.
16-11-2017
+1 [~arajkumar] Just curious to know, are we missing some more functionality to make below 2 cases to pass ? running fast/events/before-unload-navigate-different-window.html -> failed running fast/events/before-unload-open-window.html -> failed Below are some of the "before unload" test cases which got skipped for win and ios ports. [~dkumar] Can you update the skiplist with below info for windows port as part of JDK-8190761 ? 1) https://trac.webkit.org/browser/webkit/trunk/LayoutTests/platform/win/TestExpectations fast/events/beforeunload-showModalDialog.html [ Skip ] fast/events/beforeunload-dom-manipulation-crash.html [ Crash ] 2) https://trac.webkit.org/browser/webkit/trunk/LayoutTests/platform/ios/TestExpectations fast/events/beforeunload-alert-handled-keydown.html [ Skip ] fast/events/beforeunload-alert-unhandled-keydown.html [ Skip ] fast/events/beforeunload-alert-user-interaction.html [ Skip ]
14-11-2017
[~mbilla], Thanks for your comments, PSB Addressed your concerns(#1, #2, #3) in new webrev: http://cr.openjdk.java.net/~arajkumar/8089264/webrev.01/ For #4, running fast/events/before-unload-navigate-different-window.html -> failed running fast/events/before-unload-open-window.html -> failed running fast/events/before-unload-return-string-conversion.html -> succeeded running fast/events/before-unload-returnValue.html -> succeeded running fast/events/before-unload-sibling-frame.html -> succeeded For #5, Yes, otherwise method can't be accessible from UIClientImpl class.
14-11-2017
Few Minor Comments: 1) UIClientImpl.java -> You can keep @Override on same line as function declaration for canRunBeforeUnloadConfirmPanel and runBeforeUnloadConfirmPanel (similar to other methods in the file) 2) Pls update copyright year UIClientImpl.java , drt/UIClientImpl.java, UIClient.java, WebPage.java 3) Not sure whether for files DumpRenderTree.cpp and ChromeClientJava.cpp , are we already updated GPL license ? 4) I see below related failures/ timeouts for "before unload (taken from windows and Linux DRT results ). I hope you tested below DRT cases as well ? fast/events/before-unload-navigate-different-window.html -> failed fast/events/before-unload-open-window.html -> failed fast/events/before-unload-return-string-conversion.html -> timed out fast/events/before-unload-returnValue.html -> timed out fast/events/before-unload-sibling-frame.html -> timed out 5) shouldStayOnPageAfterHandlingBeforeUnload is need to be protected ?
13-11-2017
+1
07-11-2017
Problem: DRT uses testRunner.setShouldStayOnPageAfterHandlingBeforeUnload function to control the behaviour of "onbeforeunload" event. Currently we are not doing anything for "onbeforeunload" Solution: Delegate a "onbeforeunload" handler to UI client, and from DRT specific UIClient read the value from testRunner.shouldStayOnPageAfterHandlingBeforeUnload and return it to test. webrev: http://cr.openjdk.java.net/~arajkumar/8089264/webrev (Proposed solution is based on Windows and Mac Legacy WebKit ports)
06-11-2017
Fix is will be done on DRT framework, no functional change expected from WebKit side.
02-11-2017
Targeted to 10 as an issue introduced in 8u or 9
17-02-2017
Approved by component triage team to defer
23-06-2016
This bug was found while baselining new Webkit in 8u40 with new DRT. The WebKit was not integrated and new DRT is not used. SQE is ok to defer from 8u40 but bugs should be targeted to the release where dev plans to integrate new WebKit.
18-11-2014