JDK-8240231 : Build failure on illumos after 8238988
  • Type: Bug
  • Component: hotspot
  • Sub-Component: runtime
  • Affected Version: 15
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • OS: solaris
  • CPU: x86_64
  • Submitted: 2020-02-28
  • Updated: 2020-03-05
  • Resolved: 2020-02-28
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 15
15 b13Fixed
Related Reports
Relates :  
Description
On 2/28/20 8:16 AM, Peter Tribble wrote:
> Hi,
>
> I'm building from source on illumos. After
>
> 8238988: Rename thread "in stack" methods and add in_stack_range
>
> I get a build failure:
>
> "/export/home/ptribble/ud/jdk-jdk-15+12/src/hotspot/os_cpu/solaris_x86/thread_solaris_x86.cpp",
> line 92: Error: Formal argument limit of type unsigned char* in call to
> Thread::is_in_stack_range_incl(unsigned char*, unsigned char*) const is
> being passed long*.
> 1 Error(s) detected.
>
> Looking at line 92 of src/hotspot/os_cpu/solaris_x86/thread_solaris_x86.cpp:
>
>     if (!jt->is_in_stack_range_incl((address)ret_fp, ret_sp)) {
>
> shouldn't the 2nd argument also be cast, as the signature has both being
> the same type? Like so:
>
>     if (!jt->is_in_stack_range_incl((address)ret_fp, (address)ret_sp)) {
>
> with that change, I get a clean build again, and a working jdk.
>
> Thanks,
>

Comments
URL: https://hg.openjdk.java.net/jdk/jdk/rev/1a57db1b936f User: dcubed Date: 2020-02-28 15:17:31 +0000
28-02-2020