JDK-8238988 : Rename thread "in stack" methods and add is_in_stack_range
  • Type: Enhancement
  • Component: hotspot
  • Sub-Component: runtime
  • Affected Version: 15
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • Submitted: 2020-02-13
  • Updated: 2020-02-28
  • Resolved: 2020-02-24
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 15
15 b12Fixed
Related Reports
Relates :  
JDK-8239895 - assert(_stack_base != 0LL) failed: Sanity check
Relates :  
JDK-8240141 - Incorrect copyright header in src/hotspot/os_cpu/linux_sparc/os_linux_sparc.cpp
Relates :  
JDK-8234372 - Investigate use of Thread::stack_base() and queries for "in stack"
Relates :  
JDK-8240231 - Build failure on illumos after 8238988
Description
Following on from JDK-8234372:

I think some renaming is needed here:

Thread::is_in_stack -> Thread::is_in_live_stack
Thread::on_local_stack -> Thread::is_in_full_stack   // I wanted to use "mapped" to imply full stack segment but "mapped" has a special meaning at the OS page level

We should also add is_in_stack_range that takes a limit and checks that stack_base() > addr >= limit  && limit <= stack_end(). This will avoid direct uses of stack_base() in many cases and avoid problems with checking >= versus > etc. Whether the limit is inclusive or exclusive may also have to be specified.
Comments
URL: https://hg.openjdk.java.net/jdk/jdk/rev/23363df27cb6 User: dholmes Date: 2020-02-24 03:37:50 +0000
24-02-2020