JDK-8220503 : Move definition of ShenandoahTerminatorTerminator::should_exit_termination() to .cpp file
  • Type: Enhancement
  • Component: hotspot
  • Sub-Component: gc
  • Affected Version: 11-shenandoah,12,13,14
  • Priority: P4
  • Status: Resolved
  • Resolution: Fixed
  • OS: generic
  • CPU: generic
  • Submitted: 2019-03-12
  • Updated: 2022-02-24
  • Resolved: 2020-03-09
The Version table provides details related to the release that this issue/RFE will be addressed.

Unresolved : Release in which this issue/RFE will be addressed.
Resolved: Release in which this issue/RFE has been resolved.
Fixed : Release in which this issue/RFE has been fixed. The release containing this fix may be available for download as an Early Access Release or a General Availability Release.

To download the current JDK release, click here.
JDK 14 JDK 15
14.0.2Fixed 15 b14Fixed
Description
In shenandoah/jdk8u, I needed to move ShenandoahTerminatorTerminator::should_exit_termination() into shenandoahTaskQueue.cpp to resolve an include circle. We can't use ShenandoahHeap methods from the .hpp file. For code consistency, this should be done in upstream too.
Comments
Fix Request (14u) This simplifies Shenandoah maintenance by leveling the ground for subsequent backports. Patch applies cleanly to 14u, passes hotspot_gc_shenandoah, tier{1,2} with Shenandoah enabled. Risk is low, and the whole change is contained in Shenandoah code.
20-04-2020
Already done in 8-shenandoah, dropping affected version
16-04-2020
URL: https://hg.openjdk.java.net/jdk/jdk/rev/598ac6de2237 User: rkennke Date: 2020-03-09 11:52:14 +0000
09-03-2020
This should be worked on, right?
20-09-2019